GonnaHetzMe/wotbreplay-parser
1
0 Fork 0
mirror of https://github.com/eigenein/wotbreplay-parser.git synced 2026-10-24 11:49:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

Opt: avoid the buffer allocation, use a reader

Browse Source
This commit is contained in:
Pavel Perestoronin committed 2022-12-03 17:49:47 +01:00
1 parent 21206737c0
commit 679b0ddadf
1 file changed
+2 -6
Download Patch File Download Diff File Expand all files Collapse all files
src/replay.rs
+2 -6
View File
@@ -18,16 +18,12 @@ impl<R: Read + Seek> Replay<R> {
} }
pub fn read_battle_results(&mut self) -> Result<BattleResults> { pub fn read_battle_results(&mut self) -> Result<BattleResults> {
let mut pickled_battle_results = self let pickled_battle_results = self
.0 .0
.by_name("battle_results.dat") .by_name("battle_results.dat")
.map_err(Error::OpenBattleResultsFailed)?; .map_err(Error::OpenBattleResultsFailed)?;
let mut serialized_battle_results = Vec::new();
pickled_battle_results
.read_to_end(&mut serialized_battle_results)
.map_err(Error::ReadEntryFailed)?;
let battle_results_dat: BattleResultsDat = let battle_results_dat: BattleResultsDat =
serde_pickle::from_slice(&serialized_battle_results, Default::default()) serde_pickle::from_reader(pickled_battle_results, Default::default())
.map_err(Error::UnpickleFailed)?; .map_err(Error::UnpickleFailed)?;
BattleResults::decode(battle_results_dat.1.as_ref()).map_err(Error::DecodeFailed) BattleResults::decode(battle_results_dat.1.as_ref()).map_err(Error::DecodeFailed)
} }