From 059358cff494befe7641290c409d718848fa5834 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com>
Date: Tue, 6 Feb 2024 13:34:23 -0600
Subject: [PATCH] feat: put other in end

---
 src/core/blitzkrieg/tankDefinitions.ts | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/core/blitzkrieg/tankDefinitions.ts b/src/core/blitzkrieg/tankDefinitions.ts
index 4384c400b..748c19256 100644
--- a/src/core/blitzkrieg/tankDefinitions.ts
+++ b/src/core/blitzkrieg/tankDefinitions.ts
@@ -183,11 +183,12 @@ export const TIER_ROMAN_NUMERALS: Record<Tier, string> = {
 };
 
 export const NATIONS = tanksDefinitionsArray.then((tanks) => {
-  const nationsObject: Record<string, true> = {};
+  const nations = Array.from(
+    new Set<string>(Object.values(tanks).map((tank) => tank.nation)),
+  );
 
-  tanks.forEach(({ nation }) => {
-    nationsObject[nation] = true;
-  });
+  nations.splice(nations.indexOf('other'), 1);
+  nations.push('other');
 
-  return Object.keys(nationsObject);
+  return nations;
 });