From 2272cd319edad0ac66cde76cf5001113479c2ba6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com>
Date: Sat, 13 Jul 2024 14:31:12 -0500
Subject: [PATCH] fix: better default provision algorithm

---
 src/core/blitzkit/tankToDuelMember.ts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/core/blitzkit/tankToDuelMember.ts b/src/core/blitzkit/tankToDuelMember.ts
index e965edf96..8deb18456 100644
--- a/src/core/blitzkit/tankToDuelMember.ts
+++ b/src/core/blitzkit/tankToDuelMember.ts
@@ -10,6 +10,10 @@ const PROVISION_PREFERENCES = [
   22, // protective kit
 ];
 
+function infinityFallback(value: number) {
+  return value === -1 ? Infinity : value;
+}
+
 export function tankToDuelMember(
   tank: TankDefinition,
   provisionDefinitions: ProvisionDefinitions,
@@ -27,8 +31,8 @@ export function tankToDuelMember(
     provisions: provisionsList
       .sort(
         (a, b) =>
-          PROVISION_PREFERENCES.indexOf(a.id) -
-          PROVISION_PREFERENCES.indexOf(b.id),
+          infinityFallback(PROVISION_PREFERENCES.indexOf(a.id)) -
+          infinityFallback(PROVISION_PREFERENCES.indexOf(b.id)),
       )
       .sort((a, b) => (b.crew ?? 0) - (a.crew ?? 0))
       .slice(0, tank.provisions)