feat: integrated tank definitions

src/app/embeds/session/page.tsx

@@ -7,9 +7,9 @@ import { TreeTypeEnum } from '../../../components/Tanks';
 import { WARGAMING_APPLICATION_ID } from '../../../constants/wargamingApplicationID';
 import fetchBlitz from '../../../core/blitz/fetchBlitz';
 import {
-  BlitzkriegTankDefinition,
+  TankDefinition,
   tankDefinitions,
-} from '../../../core/blitzkrieg/definitions/tanks';
+} from '../../../core/blitzkrieg/tankDefinitions';
 import { tankAverages } from '../../../core/blitzstars/tankAverages';
 import calculateWN8 from '../../../core/statistics/calculateWN8';
 import { deltaTankStats } from '../../../core/statistics/deltaTankStats';
@@ -30,7 +30,7 @@ export default function SessionPage() {
 
         list: {
           stats: IndividualTankStats;
-          tankDefinitions?: BlitzkriegTankDefinition;
+          tankDefinitions?: TankDefinition;
           career: IndividualTankStats;
           currentWN8?: number;
           careerWN8?: number;

src/app/tools/tankopedia/[id]/page.tsx

@@ -12,7 +12,6 @@ import {
   Dialog,
   Flex,
   Heading,
-  Separator,
   Slider,
   Tabs,
   Text,
@@ -27,52 +26,64 @@ import { debounce } from 'lodash';
 import Link from 'next/link';
 import { use, useEffect, useRef, useState } from 'react';
 import { Flag } from '../../../../components/Flag';
+import { ModuleButtons } from '../../../../components/ModuleButton';
 import PageWrapper from '../../../../components/PageWrapper';
 import { asset } from '../../../../core/blitzkrieg/asset';
 import { gunDefinitions } from '../../../../core/blitzkrieg/definitions/guns';
 import { shellDefinitions } from '../../../../core/blitzkrieg/definitions/shells';
+import { turretDefinitions } from '../../../../core/blitzkrieg/definitions/turrets';
 import {
   TIER_ROMAN_NUMERALS,
   tankDefinitions,
   tankNamesDiacritics,
-  tanksDefinitionsArray,
-} from '../../../../core/blitzkrieg/definitions/tanks';
-import { turretDefinitions } from '../../../../core/blitzkrieg/definitions/turrets';
+} from '../../../../core/blitzkrieg/tankDefinitions';
 import * as styles from '../page.css';
 
-type Mode = 'model' | 'armor';
-
 export default function Page({ params }: { params: { id: string } }) {
   const id = parseInt(params.id);
   const awaitedTankDefinitions = use(tankDefinitions);
-  const awaitedTanksDefinitionsArray = use(tanksDefinitionsArray);
   const awaitedTurretDefinitions = use(turretDefinitions);
   const awaitedGunDefinitions = use(gunDefinitions);
   const awaitedShellDefinitions = use(shellDefinitions);
   const awaitedTankNamesDiacritics = use(tankNamesDiacritics);
   const tank = awaitedTankDefinitions[id];
   const [turret, setTurret] = useState(
-    awaitedTurretDefinitions[tank.turrets[0]],
+    awaitedTurretDefinitions[tank.turrets.at(-1)!],
   );
-  const [gun, setGun] = useState(awaitedGunDefinitions[turret.guns[0]]);
+  const [gun, setGun] = useState(awaitedGunDefinitions[turret.guns.at(-1)!]);
   const [crew, setCrew] = useState(100);
-  const [versusTankId, setVersusTankId] = useState(
-    awaitedTanksDefinitionsArray[0].id,
-  );
-  const [mode, setMode] = useState<Mode>('model');
+  const [mode, setMode] = useState('model');
   const versusTankSearchInput = useRef<HTMLInputElement>(null);
   const [versusTankSearchResults, setVersusTankSearchResults] = useState<
     number[]
   >([]);
-  const [versusTankTurretId, setVersusTankTurretId] = useState(
-    awaitedTurretDefinitions[tank.turrets[0]].id,
+  const [versusTank, setVersusTank] = useState(tank);
+  const [versusTurret, setVersusTurret] = useState(
+    awaitedTurretDefinitions[versusTank.turrets.at(-1)!],
   );
-  const versusTank = awaitedTankDefinitions[versusTankId];
+  const [versusGun, setVersusGun] = useState(
+    awaitedGunDefinitions[versusTurret.guns.at(-1)!],
+  );
+  const [versusTankTab, setVersusTankTab] = useState('search');
 
-  useEffect(() => setGun(awaitedGunDefinitions[turret.guns[0]]), [turret]);
+  useEffect(() => {
+    if (!turret.guns.includes(gun.id)) {
+      setGun(awaitedGunDefinitions[turret.guns.at(-1)!]);
+    }
+  }, [turret]);
+  useEffect(() => {
+    if (!versusTank.turrets.includes(versusTurret.id)) {
+      setVersusTurret(awaitedTurretDefinitions[versusTank.turrets.at(-1)!]);
+    }
+  }, [versusTank]);
+  useEffect(() => {
+    if (!versusTurret.guns.includes(versusGun.id)) {
+      setVersusGun(awaitedGunDefinitions[versusTurret.guns.at(-1)!]);
+    }
+  }, [versusTurret]);
 
   return (
-    <PageWrapper>
+    <PageWrapper color="purple">
       <Flex gap="8" direction="column">
         <Flex gap="4" direction="column">
           <Flex justify="between" align="center">
@@ -94,10 +105,7 @@ export default function Page({ params }: { params: { id: string } }) {
 
           <Card style={{ position: 'relative' }}>
             <Flex direction="column" gap="2">
-              <Tabs.Root
-                value={mode}
-                onValueChange={(value) => setMode(value as Mode)}
-              >
+              <Tabs.Root value={mode} onValueChange={setMode}>
                 <Tabs.List>
                   <Tabs.Trigger value="model">Model</Tabs.Trigger>
                   <Tabs.Trigger value="armor">Armor</Tabs.Trigger>
@@ -136,86 +144,191 @@ export default function Page({ params }: { params: { id: string } }) {
                   <Dialog.Root>
                     <Dialog.Trigger>
                       <Button variant="ghost">
-                        {awaitedTankDefinitions[versusTankId].name}
+                        {versusTank.name}
                         <CaretRightIcon />
                       </Button>
                     </Dialog.Trigger>
 
                     <Dialog.Content>
-                      <Flex direction="column" gap="6">
-                        <Flex direction="column" gap="2">
-                          <Heading size="4">Search tank</Heading>
+                      <Tabs.Root
+                        value={versusTankTab}
+                        onValueChange={setVersusTankTab}
+                      >
+                        <Flex gap="4" direction="column">
+                          <Tabs.List>
+                            <Tabs.Trigger value="search">Search</Tabs.Trigger>
+                            <Tabs.Trigger value="configure">
+                              Configure
+                            </Tabs.Trigger>
+                          </Tabs.List>
 
-                          <TextField.Root>
-                            <TextField.Slot>
-                              <MagnifyingGlassIcon />
-                            </TextField.Slot>
-                            <TextField.Input
-                              ref={versusTankSearchInput}
-                              placeholder="Search tank..."
-                              onChange={debounce(() => {
-                                setVersusTankSearchResults(
-                                  go(
-                                    versusTankSearchInput.current!.value,
-                                    awaitedTankNamesDiacritics,
-                                    { key: 'combined', limit: 8 },
-                                  ).map((item) => item.obj.id),
-                                );
-                              }, 500)}
-                            />
-                          </TextField.Root>
-                        </Flex>
+                          <Tabs.Content value="search">
+                            <Flex
+                              direction="column"
+                              gap="4"
+                              style={{ flex: 1 }}
+                              justify="center"
+                            >
+                              <TextField.Root>
+                                <TextField.Slot>
+                                  <MagnifyingGlassIcon />
+                                </TextField.Slot>
+                                <TextField.Input
+                                  ref={versusTankSearchInput}
+                                  placeholder="Search tank..."
+                                  onChange={debounce(() => {
+                                    setVersusTankSearchResults(
+                                      go(
+                                        versusTankSearchInput.current!.value,
+                                        awaitedTankNamesDiacritics,
+                                        { key: 'combined', limit: 8 },
+                                      ).map((item) => item.obj.id),
+                                    );
+                                  }, 500)}
+                                />
+                              </TextField.Root>
 
-                        {(versusTankSearchResults.length > 0 ||
-                          versusTankSearchInput.current?.value) && (
-                          <Flex direction="column" gap="2">
-                            {versusTankSearchResults.map((id) => (
-                              <Button
-                                key={id}
-                                variant="ghost"
-                                onClick={() => {
-                                  setVersusTankId(id);
-                                  setVersusTankSearchResults([]);
-                                  versusTankSearchInput.current!.value = '';
-                                }}
+                              <Flex direction="column" gap="2">
+                                {(versusTankSearchResults.length > 0 ||
+                                  versusTankSearchInput.current?.value) && (
+                                  <Flex direction="column" gap="2">
+                                    {versusTankSearchResults.map((id) => (
+                                      <Button
+                                        key={id}
+                                        variant="ghost"
+                                        onClick={() => {
+                                          setVersusTank(
+                                            awaitedTankDefinitions[id],
+                                          );
+                                          setVersusTankSearchResults([]);
+                                          versusTankSearchInput.current!.value =
+                                            '';
+                                          setVersusTankTab('configure');
+                                        }}
+                                      >
+                                        {awaitedTankDefinitions[id].name}
+                                      </Button>
+                                    ))}
+
+                                    {versusTankSearchResults.length === 0 &&
+                                      (versusTankSearchInput.current
+                                        ? versusTankSearchInput.current.value
+                                            .length > 0
+                                        : false) && (
+                                        <Button disabled variant="ghost">
+                                          No search results
+                                        </Button>
+                                      )}
+                                  </Flex>
+                                )}
+                              </Flex>
+                            </Flex>
+                          </Tabs.Content>
+
+                          <Tabs.Content value="configure">
+                            <Flex direction="column" gap="4">
+                              <Flex
+                                direction="column"
+                                gap="2"
+                                style={{ flex: 1 }}
                               >
-                                {awaitedTankDefinitions[id].name}
-                              </Button>
-                            ))}
+                                <Heading size="4">Configuration</Heading>
 
-                            {versusTankSearchResults.length === 0 &&
-                              (versusTankSearchInput.current
-                                ? versusTankSearchInput.current.value.length > 0
-                                : false) && (
-                                <Button disabled variant="ghost">
-                                  No search results
-                                </Button>
-                              )}
-                          </Flex>
-                        )}
+                                <Flex gap="2" wrap="wrap">
+                                  <Flex>
+                                    {versusTank.turrets.map((id, index) => (
+                                      <Tooltip
+                                        content={
+                                          awaitedTurretDefinitions[id].name
+                                        }
+                                      >
+                                        <ModuleButtons
+                                          key={id}
+                                          onClick={() =>
+                                            setVersusTurret(
+                                              awaitedTurretDefinitions[id],
+                                            )
+                                          }
+                                          selected={versusTurret.id === id}
+                                          tier={
+                                            awaitedTurretDefinitions[id].tier
+                                          }
+                                          type="turret"
+                                          style={{
+                                            margin: -0.5,
+                                            borderTopLeftRadius:
+                                              index === 0 ? undefined : 0,
+                                            borderBottomLeftRadius:
+                                              index === 0 ? undefined : 0,
+                                            borderTopRightRadius:
+                                              index ===
+                                              versusTank.turrets.length - 1
+                                                ? undefined
+                                                : 0,
+                                            borderBottomRightRadius:
+                                              index ===
+                                              versusTank.turrets.length - 1
+                                                ? undefined
+                                                : 0,
+                                          }}
+                                        />
+                                      </Tooltip>
+                                    ))}
+                                  </Flex>
+                                  <Flex>
+                                    {versusTurret.guns.map((id, index) => (
+                                      <Tooltip
+                                        content={awaitedGunDefinitions[id].name}
+                                      >
+                                        <ModuleButtons
+                                          key={id}
+                                          onClick={() =>
+                                            setVersusGun(
+                                              awaitedGunDefinitions[id],
+                                            )
+                                          }
+                                          selected={versusGun.id === id}
+                                          tier={awaitedGunDefinitions[id].tier}
+                                          type="gun"
+                                          style={{
+                                            margin: -0.5,
+                                            borderTopLeftRadius:
+                                              index === 0 ? undefined : 0,
+                                            borderBottomLeftRadius:
+                                              index === 0 ? undefined : 0,
+                                            borderTopRightRadius:
+                                              index ===
+                                              versusTurret.guns.length - 1
+                                                ? undefined
+                                                : 0,
+                                            borderBottomRightRadius:
+                                              index ===
+                                              versusTurret.guns.length - 1
+                                                ? undefined
+                                                : 0,
+                                          }}
+                                        />
+                                      </Tooltip>
+                                    ))}
+                                  </Flex>
+                                </Flex>
+                              </Flex>
 
-                        <Separator style={{ width: '100%' }} />
-
-                        <Flex direction="column" gap="2">
-                          <Heading size="4">
-                            {awaitedTankDefinitions[versusTankId].name}
-                          </Heading>
-
-                          <Flex>
-                            {versusTank.turrets.map((id) => (
-                              <Button
-                                key={id}
-                                variant="ghost"
-                                onClick={() => setVersusTankTurretId(id)}
-                                radius="small"
-                                color="gray"
+                              <Flex
+                                direction="column"
+                                gap="2"
+                                style={{ flex: 1 }}
                               >
-                                {awaitedTurretDefinitions[id].name}
-                              </Button>
-                            ))}
-                          </Flex>
+                                <Heading size="4">Properties</Heading>
+
+                                <ul>
+                                  <li>Penetration</li>
+                                </ul>
+                              </Flex>
+                            </Flex>
+                          </Tabs.Content>
                         </Flex>
-                      </Flex>
+                      </Tabs.Root>
                     </Dialog.Content>
                   </Dialog.Root>
                 </Flex>
@@ -227,17 +340,25 @@ export default function Page({ params }: { params: { id: string } }) {
 
                 <Flex gap="1">
                   <Button variant="solid" radius="small">
-                    <img src={asset('shells/ap.webp')} width={24} height={24} />
-                  </Button>
-                  <Button variant="soft" radius="small" color="gray">
                     <img
-                      src={asset('shells/hc_premium.webp')}
+                      src={asset('icons/shells/ap.webp')}
                       width={24}
                       height={24}
                     />
                   </Button>
                   <Button variant="soft" radius="small" color="gray">
-                    <img src={asset('shells/he.webp')} width={24} height={24} />
+                    <img
+                      src={asset('icons/shells/hc_premium.webp')}
+                      width={24}
+                      height={24}
+                    />
+                  </Button>
+                  <Button variant="soft" radius="small" color="gray">
+                    <img
+                      src={asset('icons/shells/he.webp')}
+                      width={24}
+                      height={24}
+                    />
                   </Button>
                 </Flex>
               </Flex>

src/app/tools/tankopedia/components/Options/index.tsx

@@ -15,7 +15,7 @@ import {
   NATIONS,
   TIERS,
   TIER_ROMAN_NUMERALS,
-} from '../../../../../core/blitzkrieg/definitions/tanks';
+} from '../../../../../core/blitzkrieg/tankDefinitions';
 import mutateTankopedia, {
   TankopediaTestTankDisplay,
   useTankopedia,

src/app/tools/tankopedia/components/PageTurner.tsx

@@ -1,12 +1,12 @@
 import { CaretLeftIcon, CaretRightIcon } from '@radix-ui/react-icons';
 import { Button, Flex, TextField } from '@radix-ui/themes';
 import { useEffect, useRef } from 'react';
-import { BlitzkriegTankDefinition } from '../../../../core/blitzkrieg/definitions/tanks';
+import { TankDefinition } from '../../../../core/blitzkrieg/tankDefinitions';
 
 interface PageTurnerProps {
   page: number;
   setPage: (page: number) => void;
-  searchedList: BlitzkriegTankDefinition[];
+  searchedList: TankDefinition[];
   tanksPerPage: number;
 }
 

src/app/tools/tankopedia/page.tsx

@@ -20,13 +20,13 @@ import { Suspense, use, useEffect, useMemo, useRef, useState } from 'react';
 import PageWrapper from '../../../components/PageWrapper';
 import { asset } from '../../../core/blitzkrieg/asset';
 import {
-  BlitzkriegTankDefinition,
   TANK_ICONS,
   TANK_ICONS_COLLECTOR,
   TANK_ICONS_PREMIUM,
   TIER_ROMAN_NUMERALS,
+  TankDefinition,
   tanksDefinitionsArray,
-} from '../../../core/blitzkrieg/definitions/tanks';
+} from '../../../core/blitzkrieg/tankDefinitions';
 import { tankIcon } from '../../../core/blitzkrieg/tankIcon';
 import { theme } from '../../../stitches.config';
 import mutateTankopedia, {
@@ -117,10 +117,7 @@ export default function Page() {
                   } else {
                     setSearchedList(
                       go(event.target.value, searchableTanks, {
-                        keys: [
-                          'name',
-                          'id',
-                        ] satisfies (keyof BlitzkriegTankDefinition)[],
+                        keys: ['name', 'id'] satisfies (keyof TankDefinition)[],
                       }).map(({ obj }) => obj),
                     );
                   }

src/commands/breakdown.tsx

@@ -8,8 +8,8 @@ import { AllStats, getAccountInfo } from '../core/blitz/getAccountInfo';
 import { getClanAccountInfo } from '../core/blitz/getClanAccountInfo';
 import getTankStats from '../core/blitz/getTankStats';
 import getTreeType from '../core/blitz/getTreeType';
-import { tankDefinitions } from '../core/blitzkrieg/definitions/tanks';
 import { filtersToDescription } from '../core/blitzkrieg/filtersToDescription';
+import { tankDefinitions } from '../core/blitzkrieg/tankDefinitions';
 import { getBlitzStarsLinkButton } from '../core/blitzstars/getBlitzStarsLinkButton';
 import getStatsInPeriod from '../core/blitzstars/getStatsInPeriod';
 import { tankAverages } from '../core/blitzstars/tankAverages';

src/commands/eligible.ts

@@ -1,8 +1,8 @@
 import { SlashCommandBuilder } from 'discord.js';
 import { getAccountInfo } from '../core/blitz/getAccountInfo';
-import { tankDefinitions } from '../core/blitzkrieg/definitions/tanks';
 import getPeriodNow from '../core/blitzkrieg/getPeriodNow';
 import getTimeDaysAgo from '../core/blitzkrieg/getTimeDaysAgo';
+import { tankDefinitions } from '../core/blitzkrieg/tankDefinitions';
 import getStatsInPeriod from '../core/blitzstars/getStatsInPeriod';
 import { tankAverages } from '../core/blitzstars/tankAverages';
 import addUsernameChoices from '../core/discord/addUsernameChoices';

src/commands/ownedTanks.tsx

@@ -8,13 +8,13 @@ import { getAccountInfo } from '../core/blitz/getAccountInfo';
 import { getClanAccountInfo } from '../core/blitz/getClanAccountInfo';
 import getTankStats from '../core/blitz/getTankStats';
 import getTreeType from '../core/blitz/getTreeType';
+import { emblemIdToURL } from '../core/blitzkrieg/emblemIdToURL';
 import {
-  BlitzkriegTankDefinition,
   TIER_ROMAN_NUMERALS,
+  TankDefinition,
   Tier,
   tankDefinitions,
-} from '../core/blitzkrieg/definitions/tanks';
-import { emblemIdToURL } from '../core/blitzkrieg/emblemIdToURL';
+} from '../core/blitzkrieg/tankDefinitions';
 import { tankIcon } from '../core/blitzkrieg/tankIcon';
 import addTierChoices from '../core/discord/addTierChoices';
 import addUsernameChoices from '../core/discord/addUsernameChoices';
@@ -47,7 +47,7 @@ export const ownedTanksCommand: CommandRegistry = {
       )
     ).filter((tank) => tank.tankDefinitions?.tier === tier);
     const clanAccountInfo = await getClanAccountInfo(server, id, ['clan']);
-    const groupedTanks: Record<string, BlitzkriegTankDefinition[]> = {};
+    const groupedTanks: Record<string, TankDefinition[]> = {};
     const nations: string[] = [];
 
     filteredTanks.forEach((tank) => {

src/commands/searchTanks.ts

@@ -1,7 +1,7 @@
 import { SlashCommandBuilder } from 'discord.js';
 import { go } from 'fuzzysort';
 import markdownEscape from 'markdown-escape';
-import { tankNamesDiacritics } from '../core/blitzkrieg/definitions/tanks';
+import { tankNamesDiacritics } from '../core/blitzkrieg/tankDefinitions';
 import addTankChoices from '../core/discord/addTankChoices';
 import embedInfo from '../core/discord/embedInfo';
 import { CommandRegistry } from '../events/interactionCreate';

src/components/ModuleButton.tsx

@@ -0,0 +1,60 @@
+import { Button, Text } from '@radix-ui/themes';
+import { ComponentProps } from 'react';
+import { asset } from '../core/blitzkrieg/asset';
+import { TIER_ROMAN_NUMERALS, Tier } from '../core/blitzkrieg/tankDefinitions';
+
+interface ModuleButtonProps
+  extends Omit<ComponentProps<typeof Button>, 'type'> {
+  type: string;
+  tier: Tier;
+  selected?: boolean;
+}
+
+export function ModuleButtons({
+  type,
+  tier,
+  selected,
+  style,
+  ...props
+}: ModuleButtonProps) {
+  return (
+    <Button
+      radius="medium"
+      color={selected ? undefined : 'gray'}
+      variant={selected ? 'solid' : 'soft'}
+      style={{
+        padding: 0,
+        width: 48,
+        height: 40,
+        position: 'relative',
+        ...style,
+      }}
+      {...props}
+    >
+      <img
+        src={asset(`icons/modules/${type}.webp`)}
+        style={{
+          width: 32,
+          height: 32,
+          position: 'absolute',
+          top: '50%',
+          left: '50%',
+          transform: 'translate(calc(-50% + 2px), calc(-50% + 2px))',
+        }}
+      />
+      <Text
+        size="1"
+        weight="bold"
+        style={{
+          zIndex: 1,
+          position: 'absolute',
+          top: '50%',
+          right: 8,
+          textAlign: 'right',
+        }}
+      >
+        {TIER_ROMAN_NUMERALS[tier]}
+      </Text>
+    </Button>
+  );
+}

src/components/Tanks/components/Item.tsx

@@ -2,7 +2,7 @@ import {
   TANK_ICONS,
   TANK_ICONS_COLLECTOR,
   TANK_ICONS_PREMIUM,
-} from '../../../core/blitzkrieg/definitions/tanks';
+} from '../../../core/blitzkrieg/tankDefinitions';
 import { theme } from '../../../stitches.config';
 
 export enum TreeTypeEnum {

src/components/TierWeights.tsx

@@ -1,4 +1,4 @@
-import { Tier } from '../core/blitzkrieg/definitions/tanks';
+import { Tier } from '../core/blitzkrieg/tankDefinitions';
 import { theme } from '../stitches.config';
 
 export type TierWeightsRecord = Partial<Record<Tier, number>>;

src/core/blitz/getTreeType.ts

@@ -1,5 +1,5 @@
 import { TreeTypeEnum } from '../../components/Tanks';
-import { tankDefinitions } from '../blitzkrieg/definitions/tanks';
+import { tankDefinitions } from '../blitzkrieg/tankDefinitions';
 
 export default async function getTreeType(id: number) {
   const entry = (await tankDefinitions)[id];

src/core/blitz/resolveTankId.ts

@@ -2,7 +2,7 @@ import { go } from 'fuzzysort';
 import {
   tankDefinitions,
   tanksDefinitionsArray,
-} from '../blitzkrieg/definitions/tanks';
+} from '../blitzkrieg/tankDefinitions';
 import { UserError } from '../blitzkrieg/userError';
 
 export default async function resolveTankId(tank: string | number) {

src/core/blitzkrieg/definitions/guns.ts

@@ -1,18 +0,0 @@
-import { asset } from '../asset';
-import { Tier } from './tanks';
-
-export interface BlitzkriegGunDefinition {
-  id: number;
-  name: string;
-  tier: Tier;
-  pitch: [number, number];
-  shells: number[];
-}
-
-export type BlitzkriegGunDefinitions = Record<number, BlitzkriegGunDefinition>;
-
-export const gunDefinitions = fetch(asset('definitions/guns.json'), {
-  cache: 'no-cache',
-}).then(
-  async (response) => response.json() as Promise<BlitzkriegGunDefinitions>,
-);

src/core/blitzkrieg/definitions/shells.ts

@@ -1,26 +0,0 @@
-import { asset } from '../asset';
-
-export type ShellType = 'ap' | 'ap_cr' | 'hc' | 'he';
-
-export interface BlitzkriegShellDefinition {
-  id: number;
-  name: string;
-  speed: number;
-  damage: { armor: number; devices: number };
-  caliber: number;
-  normalization: number;
-  ricochet: number;
-  type: ShellType;
-  icon: string;
-}
-
-export type BlitzkriegShellDefinitions = Record<
-  number,
-  BlitzkriegShellDefinition
->;
-
-export const shellDefinitions = fetch(asset('definitions/shells.json'), {
-  cache: 'no-cache',
-}).then(
-  async (response) => response.json() as Promise<BlitzkriegShellDefinitions>,
-);

src/core/blitzkrieg/definitions/turrets.ts

@@ -1,21 +0,0 @@
-import { asset } from '../asset';
-import { Tier } from './tanks';
-
-export interface BlitzkriegTurretDefinition {
-  id: number;
-  name: string;
-  tier: Tier;
-  yaw: [number, number];
-  guns: number[];
-}
-
-export type BlitzkriegTurretDefinitions = Record<
-  number,
-  BlitzkriegTurretDefinition
->;
-
-export const turretDefinitions = fetch(asset('definitions/turrets.json'), {
-  cache: 'no-cache',
-}).then(
-  async (response) => response.json() as Promise<BlitzkriegTurretDefinitions>,
-);

src/core/blitzkrieg/filtersToDescription.ts

@@ -1,11 +1,7 @@
 import { TREE_TYPE_NAMES } from '../../components/Tanks';
 import { encyclopediaInfo } from '../blitz/encyclopediaInfo';
 import { StatFilters } from '../statistics/filterStats';
-import {
-  TIER_ROMAN_NUMERALS,
-  Tier,
-  tankDefinitions,
-} from './definitions/tanks';
+import { TIER_ROMAN_NUMERALS, Tier, tankDefinitions } from './tankDefinitions';
 
 export async function filtersToDescription({
   nation,

src/core/blitzkrieg/tankDefinitions.ts

@@ -1,8 +1,51 @@
 import { deburr } from 'lodash';
-import { TankType, TreeTypeString } from '../../../components/Tanks';
-import { asset } from '../asset';
+import { TankType, TreeTypeString } from '../../components/Tanks';
+import { asset } from './asset';
 
-export interface BlitzkriegTankDefinition {
+export type ShellType = 'ap' | 'ap_cr' | 'hc' | 'he';
+export interface ShellDefinition {
+  id: number;
+  name: string;
+  speed: number;
+  damage: { armor: number; devices: number };
+  caliber: number;
+  normalization: number;
+  ricochet: number;
+  type: ShellType;
+  icon: string;
+}
+export type GunDefinition = {
+  id: number;
+  name: string;
+  tier: Tier;
+  pitch: [number, number];
+  shells: ShellDefinition[];
+} & (
+  | {
+      type: 'regular';
+      reload: number;
+    }
+  | {
+      type: 'auto_loader';
+      reload: number;
+      interClip: number;
+      count: number;
+    }
+  | {
+      type: 'auto_reloader';
+      reload: number[];
+      interClip: number;
+      count: number;
+    }
+);
+export interface TurretDefinition {
+  id: number;
+  name: string;
+  tier: Tier;
+  yaw: [number, number];
+  guns: GunDefinition[];
+}
+export interface TankDefinition {
   id: number;
   nation: string;
   name: string;
@@ -10,23 +53,18 @@ export interface BlitzkriegTankDefinition {
   tier: Tier;
   type: TankType;
   testing?: boolean;
-  turrets: number[];
+  turrets: TurretDefinition[];
 }
-export type BlitzkriegTankDefinitions = Record<
-  number,
-  BlitzkriegTankDefinition
->;
+export type TankDefinitions = Record<number, TankDefinition>;
 
 export const tankDefinitions = fetch(asset('definitions/tanks.json'), {
   cache: 'no-cache',
-}).then(
-  async (response) => response.json() as Promise<BlitzkriegTankDefinitions>,
-);
+}).then(async (response) => response.json() as Promise<TankDefinitions>);
 
-const entries = new Promise<BlitzkriegTankDefinition[]>(async (resolve) => {
+const entries = new Promise<TankDefinition[]>(async (resolve) => {
   resolve(Object.entries(await tankDefinitions).map(([, entry]) => entry));
 });
-export const tanksDefinitionsArray = new Promise<BlitzkriegTankDefinition[]>(
+export const tanksDefinitionsArray = new Promise<TankDefinition[]>(
   async (resolve) => {
     resolve((await entries).map((entry) => entry));
   },

src/core/blitzkrieg/tankIcon.ts

@@ -1,5 +1,5 @@
 import { asset } from './asset';
 
 export function tankIcon(id: number, size: 'big' | 'small' = 'big') {
-  return asset(`icons/${size}/${id}.webp`);
+  return asset(`icons/tanks/${size}/${id}.webp`);
 }

src/core/blitzstars/tankAverages.ts

@@ -1,6 +1,6 @@
 import { AllStats } from '../blitz/getAccountInfo';
 import { context } from '../blitzkrieg/context';
-import { tankDefinitions } from '../blitzkrieg/definitions/tanks';
+import { tankDefinitions } from '../blitzkrieg/tankDefinitions';
 
 export interface SpecialStats {
   winrate: number;

src/core/discord/autocompleteTanks.ts

@@ -4,7 +4,7 @@ import {
   CacheType,
 } from 'discord.js';
 import { go } from 'fuzzysort';
-import { tankNamesDiacritics } from '../blitzkrieg/definitions/tanks';
+import { tankNamesDiacritics } from '../blitzkrieg/tankDefinitions';
 import {
   DISCORD_CHOICES_MAX_NAME_SIZE,
   OVERFLOW_SUFFIX,

src/core/statistics/filterStats.ts

@@ -1,5 +1,5 @@
 import { TreeTypeString } from '../../components/Tanks';
-import { tankDefinitions } from '../blitzkrieg/definitions/tanks';
+import { tankDefinitions } from '../blitzkrieg/tankDefinitions';
 import { DiffedTankStats } from '../blitzstars/getStatsInPeriod';
 import { tankAverages } from '../blitzstars/tankAverages';
 import calculateWN8 from './calculateWN8';

src/core/statistics/getTierWeights.ts

@@ -1,6 +1,6 @@
 import { TierWeightsRecord } from '../../components/TierWeights';
 import { AllStats } from '../blitz/getAccountInfo';
-import { tankDefinitions } from '../blitzkrieg/definitions/tanks';
+import { tankDefinitions } from '../blitzkrieg/tankDefinitions';
 
 export async function getTierWeights(
   stats: Record<number, AllStats>,

src/stores/tankopedia.ts

@@ -1,7 +1,7 @@
 import { produce } from 'immer';
 import { create } from 'zustand';
 import { TankType, TreeTypeString } from '../components/Tanks';
-import { Tier } from '../core/blitzkrieg/definitions/tanks';
+import { Tier } from '../core/blitzkrieg/tankDefinitions';
 
 export type TankopediaSortBy = 'tier' | 'name';
 export type TankopediaSortDirection = 'ascending' | 'descending';