feat: improved error messages

src/commands/ratings.tsx

@@ -337,11 +337,8 @@ export const ratingsCommand = new Promise<CommandRegistryRaw>(
 
                   if (playerIndex === -1) {
                     throw new UserError(
-                      `${accountInfo.nickname} didn't player ratings in season ${season}`,
+                      `${accountInfo.nickname} didn't play ratings in season ${season}`,
-                      {
+                      'This player did not participate in this season or did not get past calibration.',
-                        cause:
-                          'This player did not participate in this season or did not get past calibration.',
-                      },
                     );
                   }
 

src/core/blitz/getTankStats.ts

@@ -10,10 +10,10 @@ export default async function getTankStats(region: Region, id: number) {
   );
 
   if (tankStats[id] === null) {
-    throw new UserError('No tank stats available', {
+    throw new UserError(
-      cause:
+      'No tank stats available',
-        "This player doesn't have any stats for tanks available. This may not be the player you are looking for.",
+      "This player doesn't have any stats available. This may not be the player you are looking for.",
-    });
+    );
   }
 
   return tankStats[id];

src/core/blitz/resolveTankId.ts

@@ -15,9 +15,10 @@ export default async function resolveTankId(tank: string | number) {
     });
 
     if (searchResult.length === 0) {
-      throw new UserError('Tank not found', {
+      throw new UserError(
-        cause: `Could not find tank by the name "${tank}".`,
+        'Tank not found',
-      });
+        `Could not find tank by the name "${tank}".`,
+      );
     } else {
       return searchResult[0].obj.id;
     }
@@ -25,9 +26,10 @@ export default async function resolveTankId(tank: string | number) {
     if ((await tankDefinitions)[number]) {
       return number;
     } else {
-      throw new UserError('Tank not found', {
+      throw new UserError(
-        cause: `Could not find tank by the ID "${number}".`,
+        'Tank not found',
-      });
+        `Could not find tank by the ID "${number}". Try typing the name of the tank instead of a number.`,
+      );
     }
   }
 }

src/core/blitzkrieg/userError.ts

@@ -1,4 +1,9 @@
 /**
  * Discriminator for user caused errors to not report in logs
  */
-export class UserError extends Error {}
+export class UserError {
+  constructor(
+    public message: string,
+    public cause: string,
+  ) {}
+}

src/core/discord/resolveClanFromCommand.ts

@@ -18,9 +18,10 @@ export default async function resolveClanFromCommand(
     if (accounts[0]) {
       return { region: accounts[0].region, id: accounts[0].clan_id };
     } else {
-      throw new UserError('Could not find clan', {
+      throw new UserError(
-        cause: `I couldn't find clan \`${clan}\`. Try selecting a username from the search result.`,
+        'Could not find clan',
-      });
+        `\`${clan}\` was not found. Try selecting a clan from the search result.`,
+      );
     }
   }
 }

src/core/discord/resolvePlayerFromCommand.ts

@@ -34,11 +34,12 @@ export default async function resolvePlayerFromCommand(
           id: accounts[0].account_id,
         } satisfies ResolvedPlayer;
       } else {
-        throw new UserError('Could not find user', {
+        throw new UserError(
-          cause: `I couldn't find user "${markdownEscape(
+          'Could not find user',
+          `I couldn't find user "${markdownEscape(
             commandUsername,
           )}". Try picking an user from the search result, typing in a valid username, or using the \`/link\` command.`,
-        });
+        );
       }
     }
   } else {
@@ -47,9 +48,10 @@ export default async function resolvePlayerFromCommand(
     if (account) {
       return { region: account.region, id: account.blitz };
     } else {
-      throw new UserError('Use the `/link` command', {
+      throw new UserError(
-        cause: 'Link your Blitz and Discord accounts to get started.',
+        "You're account isn't linked with Blitzkrieg yet",
-      });
+        'Use the `/link` command to get started.', // TODO: add shortcut button too
+      );
     }
   }
 }