diff --git a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Crew.tsx b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Crew.tsx index b435770af..48127306e 100644 --- a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Crew.tsx +++ b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Crew.tsx @@ -68,7 +68,6 @@ export function Crew({ stats }: StatsAcceptorProps) { ? ` ${literals(strings.common.units.x, [`${member.count}`])}` : '' }`} - unit="%" decimals={0} noRanking value={() => @@ -83,7 +82,6 @@ export function Crew({ stats }: StatsAcceptorProps) { stats={stats} key={`${member.type}-substitute`} decimals={0} - unit="%" indent name={ <> diff --git a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Firepower.tsx b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Firepower.tsx index fbff198e6..fe806b2b7 100644 --- a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Firepower.tsx +++ b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Firepower.tsx @@ -106,15 +106,9 @@ export function Firepower({ stats }: StatsAcceptorProps) { > {strings.common.gun_types[gun.gun_type!.$case]} - + {gun.gun_type!.$case === 'auto_reloader' && ( - + )} {gun.gun_type!.$case !== 'regular' && ( @@ -135,7 +129,6 @@ export function Firepower({ stats }: StatsAcceptorProps) { strings.website.tools.tankopedia.characteristics.values .shellReloads } - unit="s" /> {stats.shellReloads!.map((reload, index) => ( @@ -169,12 +161,11 @@ export function Firepower({ stats }: StatsAcceptorProps) { stats={stats} indent decimals={2} - unit="s" deltaType="lowerIsBetter" value="intraClip" /> )} - + {typeof shell.penetration !== 'number' && ( <> )} - + {gun.gun_type!.$case !== 'regular' && ( )} - + {isExplosive(shell.type) && ( )} - + {!isExplosive(shell.type) && ( <> @@ -277,24 +261,17 @@ export function Firepower({ stats }: StatsAcceptorProps) { noRanking decimals={0} deltaType="lowerIsBetter" - unit="°" value="shellRicochet" /> )} - - + + @@ -309,7 +286,6 @@ export function Firepower({ stats }: StatsAcceptorProps) { stats={stats} decimals={3} indent - unit="m" deltaType="lowerIsBetter" value="dispersion" /> @@ -358,7 +334,6 @@ export function Firepower({ stats }: StatsAcceptorProps) { strings.website.tools.tankopedia.characteristics.values .gun_flexibility } - unit="°" /> diff --git a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Info.tsx b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Info.tsx index 27d959d7e..ce051f3a6 100644 --- a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Info.tsx +++ b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Info.tsx @@ -5,7 +5,6 @@ import type { ReactNode } from 'react'; export interface InfoProps { name: ReactNode; children?: ReactNode; - unit?: string; indent?: boolean; delta?: number; decimals?: number; @@ -16,7 +15,6 @@ export interface InfoProps { export function Info({ name, children, - unit, indent = false, delta, decimals, @@ -25,17 +23,7 @@ export function Info({ }: InfoProps) { return ( - - {name} - {unit != undefined && ( - <> - {' '} - - {unit} - - - )} - + {name} @@ -65,8 +53,14 @@ export function Info({ )} + - {prefix} + {prefix !== undefined && ( + + {prefix} + + )} + {decimals !== undefined && typeof children === 'number' ? children.toFixed(decimals) : children} diff --git a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/InfoWithDelta.tsx b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/InfoWithDelta.tsx index 1b340a7e8..00747503d 100644 --- a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/InfoWithDelta.tsx +++ b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/InfoWithDelta.tsx @@ -1,5 +1,6 @@ import { createDefaultSkills } from '@blitzkit/core'; import { Flex, Progress, Text } from '@radix-ui/themes'; +import { clamp } from 'lodash-es'; import { useMemo, type ComponentProps, type ReactNode } from 'react'; import { awaitableEquipmentDefinitions } from '../../../../../../core/awaitables/equipmentDefinitions'; import { awaitableModelDefinitions } from '../../../../../../core/awaitables/modelDefinitions'; @@ -166,10 +167,11 @@ export function InfoWithDelta({ size="1" value={goodness * 100} color={color} - style={{ height: '0.125rem' }} + style={{ height: '0.125rem', opacity: 0.5 }} /> + - {betterTanks.length + 1} / {others.length} + {clamp(betterTanks.length + 1, 1, others.length)} / {others.length} )} diff --git a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Maneuverability.tsx b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Maneuverability.tsx index ef659653d..768ce031f 100644 --- a/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Maneuverability.tsx +++ b/packages/website/src/components/Tankopedia/CharacteristicsSection/components/Characteristics/components/Maneuverability.tsx @@ -18,7 +18,6 @@ export function Maneuverability({ stats }: StatsAcceptorProps) { @@ -26,7 +25,6 @@ export function Maneuverability({ stats }: StatsAcceptorProps) { @@ -40,13 +38,11 @@ export function Maneuverability({ stats }: StatsAcceptorProps) { value="hardTerrainCoefficient" stats={stats} decimals={0} - unit="%" indent /> @@ -54,7 +50,6 @@ export function Maneuverability({ stats }: StatsAcceptorProps) { value="softTerrainCoefficient" stats={stats} decimals={0} - unit="%" indent /> - + {strings.website.tools.tankopedia.survivability.title} - + stats.fireChance * 100} /> - + stats.camouflageStill * 100} @@ -84,28 +82,24 @@ export function Survivability({ stats }: StatsAcceptorProps) { value={(stats) => stats.camouflageCaughtOnFire * 100} />