From 583522c3a2dd610ebc8591c395152516983e42b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com>
Date: Tue, 3 Sep 2024 21:57:42 -0500
Subject: [PATCH] fix: remove dynamic armor

---
 scripts/buildAssets/definitions.ts | 62 +-----------------------------
 1 file changed, 2 insertions(+), 60 deletions(-)

diff --git a/scripts/buildAssets/definitions.ts b/scripts/buildAssets/definitions.ts
index bf33bbe1d..36086d049 100644
--- a/scripts/buildAssets/definitions.ts
+++ b/scripts/buildAssets/definitions.ts
@@ -46,11 +46,6 @@ import { DATA } from './constants';
 import { Avatar } from './skillIcons';
 import { TankParameters } from './tankIcons';
 
-function ensureDynamicArmor(armor: ModelArmor) {
-  if (!armor.dynamic) armor.dynamic = { false: [], true: [] };
-  return armor as ModelArmor & Required<Pick<ModelArmor, 'dynamic'>>;
-}
-
 export interface BlitzStrings {
   [key: string]: string;
 }
@@ -469,11 +464,7 @@ export async function definitions() {
   };
 
   const gameDefinitions: GameDefinitions = {
-    version: (await readStringDVPL(`${DATA}/version.txt.dvpl`))
-      .split(' ')[0]
-      .split('.')
-      .slice(0, 3)
-      .join('.'),
+    version: (await readStringDVPL(`${DATA}/version.txt.dvpl`)).split(' ')[0],
     nations: (
       await readYAMLDVPL<AvailableNationsYaml>(
         `${DATA}/available_nations.yaml.dvpl`,
@@ -1182,7 +1173,7 @@ export async function definitions() {
                   type: blitzShellKindToBlitzkit[shell.kind],
                   explosionRadius:
                     shell.kind === 'HIGH_EXPLOSIVE'
-                      ? shell.explosionRadius ?? 0
+                      ? (shell.explosionRadius ?? 0)
                       : undefined,
                   icon: shell.icon,
                   penetration:
@@ -1268,55 +1259,6 @@ export async function definitions() {
         Object.values(tankDefinitions[tankId].tracks).forEach((track) => {
           track.xp = trackXps.get(track.id);
         });
-
-        if (tankDefinition.root.extras?.armorsStatesController) {
-          const [falsePlates, truePlates] =
-            tankDefinition.root.extras.armorsStatesController.state.map(
-              (state) => state.armors.split(' '),
-            );
-
-          function applyDynamicArmor(plates: string[], type: `${boolean}`) {
-            plates.forEach((plate) => {
-              const [name, armorIndexString] = plate.split('.');
-              const armorIndex = Number(armorIndexString.split('_')[1]);
-
-              if (name === 'hull') {
-                ensureDynamicArmor(modelDefinitions[tankId].armor).dynamic[
-                  type
-                ].push(armorIndex);
-              } else {
-                const [module, moduleIndexString] = name.split('_');
-                const moduleIndex = Number(moduleIndexString);
-
-                if (module === 'turret') {
-                  const turret = Object.values(
-                    modelDefinitions[tankId].turrets,
-                  ).find((turret) => turret.model === moduleIndex);
-                  if (!turret) throw new Error('Turret not found');
-                  ensureDynamicArmor(turret.armor).dynamic[type].push(
-                    armorIndex,
-                  );
-                } else if (module === 'gun') {
-                  Object.values(modelDefinitions[tankId].turrets).forEach(
-                    (turret) => {
-                      const gun = Object.values(turret.guns).find(
-                        (gun) => gun.model === moduleIndex,
-                      );
-                      if (!gun) throw new Error('Gun not found');
-                      ensureDynamicArmor(gun.armor).dynamic[type].push(
-                        armorIndex,
-                      );
-                    },
-                  );
-                } else
-                  throw new Error(`Unknown dynamic armor module ${module}`);
-              }
-            });
-          }
-
-          applyDynamicArmor(falsePlates, 'false');
-          applyDynamicArmor(truePlates, 'true');
-        }
       }
     }),
   );