From 63a8a67771e389b9e37c0fdb1fc3971f8b39ab4a Mon Sep 17 00:00:00 2001 From: tresabhi Date: Fri, 8 Sep 2023 16:38:08 +0000 Subject: [PATCH] fix: better approximation message and players with 0 wins are omitted --- scripts/build.js | 4 +++- src/commands/clanEvent.ts | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/build.js b/scripts/build.js index d334ec3a6..9e124599e 100644 --- a/scripts/build.js +++ b/scripts/build.js @@ -26,7 +26,9 @@ files.forEach(async (file) => { bundle: true, sourcemap: true, - minify: true, + minifyIdentifiers: false, // cause goofy errors + minifySyntax: true, + minifyWhitespace: true, logLevel: 'info', }); diff --git a/src/commands/clanEvent.ts b/src/commands/clanEvent.ts index ce101b19e..ab68f374f 100644 --- a/src/commands/clanEvent.ts +++ b/src/commands/clanEvent.ts @@ -78,6 +78,7 @@ export const clanEventCommand: CommandRegistry = { 0, ) / 2 ).toFixed(0)}\n${jointVictories + .filter(({ joinVictory }) => joinVictory) .sort((a, b) => b.joinVictory - a.joinVictory) .map( ({ id, joinVictory }) => @@ -87,7 +88,7 @@ export const clanEventCommand: CommandRegistry = { embedWarning( 'This is an approximation!', - 'Wargaming provides use with little to no information about platoons. Platooning with mixed clans may inflate the number and platooning in non-regular battles may deflate.', + "Wargaming provides very little information about platoons publicly. Caveats:\n- Players in two different clans platooning artificially inflates the total count\n- Game-mode battles aren't counted since Wargaming doesn't track them", ), ]; },