From 65b2eb8bebf49f78d18ea6ddaa3b84ca4c571719 Mon Sep 17 00:00:00 2001 From: tresabhi Date: Tue, 30 May 2023 17:31:12 +0000 Subject: [PATCH] fix: edge case for unplayed tanks --- src/commands/tankstats.tsx | 10 ++++++---- src/components/Breakdown/components/RowStat.tsx | 8 +++++++- src/components/TitleBar.tsx | 7 ++++++- 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/src/commands/tankstats.tsx b/src/commands/tankstats.tsx index 2e80d5266..be6c91374 100644 --- a/src/commands/tankstats.tsx +++ b/src/commands/tankstats.tsx @@ -18,7 +18,9 @@ import getWargamingResponse from '../core/blitz/getWargamingResponse.js'; import resolveTankId from '../core/blitz/resolveTankId.js'; import getPeriodNow from '../core/blitzstars/getPeriodNow.js'; import getPeriodicStart from '../core/blitzstars/getPeriodStart.js'; -import getTankStatsOverTime from '../core/blitzstars/getTankStatsOverTime.js'; +import getTankStatsOverTime, { + emptyAllStats, +} from '../core/blitzstars/getTankStatsOverTime.js'; import { tankopedia } from '../core/blitzstars/tankopedia.js'; import cmdName from '../core/interaction/cmdName.js'; import addStatPeriodChoices, { @@ -64,9 +66,9 @@ export default { let stats: AllStats; if (period === 'career') { - stats = tankStats[id].find( - (stats) => stats.tank_id === Number(tank), - )!.all; + stats = + tankStats[id].find((stats) => stats.tank_id === Number(tank))?.all ?? + emptyAllStats; } else { stats = ( await getTankStatsOverTime( diff --git a/src/components/Breakdown/components/RowStat.tsx b/src/components/Breakdown/components/RowStat.tsx index d7dd3dbf6..398cad660 100644 --- a/src/components/Breakdown/components/RowStat.tsx +++ b/src/components/Breakdown/components/RowStat.tsx @@ -42,7 +42,13 @@ export function RowStat({ name, value, career, delta }: RowStatProps) { /> )} - + {value} diff --git a/src/components/TitleBar.tsx b/src/components/TitleBar.tsx index 03b64e091..3c8951a89 100644 --- a/src/components/TitleBar.tsx +++ b/src/components/TitleBar.tsx @@ -1,3 +1,4 @@ +import isDev from '../core/process/isDev.js'; import { theme } from '../stitches.config.js'; export interface TitleBarProps { @@ -75,7 +76,11 @@ export default function TitleBar({ );