feat: simpler subcommands

src/core/blitzstars/getBlitzStarsLinkButton.ts

@@ -0,0 +1,18 @@
+import { Region } from '../../constants/regions';
+import { WARGAMING_APPLICATION_ID } from '../../constants/wargamingApplicationID';
+import { AccountInfo } from '../../types/accountInfo';
+import getWargamingResponse from '../blitz/getWargamingResponse';
+import linkButton from '../discord/linkButton';
+
+export async function getBlitzStarsLinkButton(region: Region, id: number) {
+  const { nickname } = (
+    await getWargamingResponse<AccountInfo>(
+      `https://api.wotblitz.${region}/wotb/account/info/?application_id=${WARGAMING_APPLICATION_ID}&account_id=${id}`,
+    )
+  )[id];
+
+  return linkButton(
+    `https://www.blitzstars.com/player/${region}/${nickname}`,
+    'BlitzStars',
+  );
+}

src/core/blitzstars/getDiffedTankStats.ts

@@ -34,6 +34,11 @@ export const emptyTankHistoryNode: TankHistoryRaw = {
   all: emptyAllStats,
 };
 
+export interface DiffedTankStats {
+  diff: Record<number, AllStats>;
+  order: number[];
+}
+
 // BIG TODO: merge this neatly with diffNormalizedTankStats
 export default async function getDiffedTankStats(
   server: Region,
@@ -66,7 +71,7 @@ export default async function getDiffedTankStats(
   const playedTanks: number[] = [];
 
   // fetch history node right before "start" and right before "end"
-  const diffed: Record<number, AllStats> = {};
+  const diff: Record<number, AllStats> = {};
   inRangeTanks.forEach((tankId) => {
     const sortedHistory = tankSortedHistory[tankId];
     const previousIndex =
@@ -77,30 +82,30 @@ export default async function getDiffedTankStats(
     const latest =
       sortedHistory[latestIndex] ?? sortedHistory[sortedHistory.length - 1];
 
-    function diff(get: (allStats: AllStats) => number) {
+    function d(get: (allStats: AllStats) => number) {
       return get(latest.all) - get(previous.all);
     }
 
     // check if there was a change in battles as games in ratings do update last_battle_time
-    if (diff((a) => a.battles) > 0) {
-      diffed[tankId] = {
-        battles: diff((a) => a.battles),
-        capture_points: diff((a) => a.capture_points),
-        damage_dealt: diff((a) => a.damage_dealt),
-        damage_received: diff((a) => a.damage_received),
-        dropped_capture_points: diff((a) => a.dropped_capture_points),
-        frags: diff((a) => a.frags),
-        frags8p: diff((a) => a.frags8p),
-        hits: diff((a) => a.hits),
-        losses: diff((a) => a.losses),
+    if (d((a) => a.battles) > 0) {
+      diff[tankId] = {
+        battles: d((a) => a.battles),
+        capture_points: d((a) => a.capture_points),
+        damage_dealt: d((a) => a.damage_dealt),
+        damage_received: d((a) => a.damage_received),
+        dropped_capture_points: d((a) => a.dropped_capture_points),
+        frags: d((a) => a.frags),
+        frags8p: d((a) => a.frags8p),
+        hits: d((a) => a.hits),
+        losses: d((a) => a.losses),
         max_frags: latest.all.max_frags,
         max_xp: latest.all.max_xp,
-        shots: diff((a) => a.shots),
-        spotted: diff((a) => a.spotted),
-        survived_battles: diff((a) => a.survived_battles),
-        win_and_survived: diff((a) => a.win_and_survived),
-        wins: diff((a) => a.wins),
-        xp: diff((a) => a.xp),
+        shots: d((a) => a.shots),
+        spotted: d((a) => a.spotted),
+        survived_battles: d((a) => a.survived_battles),
+        win_and_survived: d((a) => a.win_and_survived),
+        wins: d((a) => a.wins),
+        xp: d((a) => a.xp),
       };
 
       playedTanks.push(tankId);
@@ -116,5 +121,5 @@ export default async function getDiffedTankStats(
     return bLatest.last_battle_time - aLatest.last_battle_time;
   });
 
-  return { diffed, order };
+  return { diff, order } satisfies DiffedTankStats;
 }

src/core/blitzstars/getPeriodStart.ts

@@ -3,5 +3,7 @@ import { PeriodSize } from '../discord/addPeriodSubCommands';
 import getTimeDaysAgo from './getTimeDaysAgo';
 
 export default function getPeriodStart(region: Region, period: PeriodSize) {
-  return period === 'career' ? 0 : getTimeDaysAgo(region, parseInt(period));
+  if (period === 'career') return 0;
+  if (period === 'today') return getTimeDaysAgo(region, 1);
+  return getTimeDaysAgo(region, parseInt(period));
 }