feat: provision assignment

src/core/blitzkrieg/assignDuelMember.ts

@@ -1,10 +1,7 @@
-import { degToRad } from 'three/src/math/MathUtils';
-import { DuelMember, mutateDuel } from '../../stores/duel';
-import { genericDefaultEquipmentMatrix } from '../../stores/duel/constants';
-import { availableProvisions } from './availableProvisions';
-import { modelDefinitions } from './modelDefinitions';
+import { mutateDuel } from '../../stores/duel';
 import { provisionDefinitions } from './provisionDefinitions';
 import { tankDefinitions } from './tankDefinitions';
+import { tankToDuelMember } from './tankToDuelMember';
 
 export async function assignDuelMember(
   type: 'antagonist' | 'protagonist' | 'both',
@@ -12,37 +9,8 @@ export async function assignDuelMember(
 ) {
   const awaitedTankDefinitions = await tankDefinitions;
   const awaitedProvisionDefinitions = await provisionDefinitions;
-  const awaitedModelDefinitions = await modelDefinitions;
-  const tankModelDefinition = awaitedModelDefinitions[id];
   const tank = awaitedTankDefinitions[id];
-  const turret = tank.turrets.at(-1)!;
-  const gun = turret.guns.at(-1)!;
-  const shell = gun.shells[0];
-  const engine = tank.engines.at(-1)!;
-  const track = tank.tracks.at(-1)!;
-  const provisionsList = availableProvisions(
-    tank,
-    gun,
-    awaitedProvisionDefinitions,
-  );
-  const member: DuelMember = {
-    tank,
-    engine,
-    turret,
-    gun,
-    shell,
-    track,
-    equipmentMatrix: genericDefaultEquipmentMatrix,
-    pitch: degToRad(tankModelDefinition.turretRotation?.pitch ?? 0),
-    yaw: 0,
-    camouflage: true,
-    consumables: [],
-    cooldownBooster: 0,
-    crewMastery: 1,
-    provisions: provisionsList
-      .filter((provision) => provision.crew !== undefined)
-      .map((provision) => provision.id),
-  };
+  const member = tankToDuelMember(tank, awaitedProvisionDefinitions);
 
   mutateDuel((draft) => {
     draft.assigned = true;

src/core/blitzkrieg/tankToCompareMember.ts

@@ -1,16 +1,19 @@
 import { uniqueId } from 'lodash';
 import { CompareMember } from '../../stores/compare';
 import { createDefaultSkills } from './createDefaultSkills';
+import { ProvisionDefinitions } from './provisionDefinitions';
 import { SkillDefinitions } from './skillDefinitions';
 import { TankDefinition } from './tankDefinitions';
 import { tankToDuelMember } from './tankToDuelMember';
 
 export function tankToCompareMember(
   tank: TankDefinition,
+  provisionDefinitions: ProvisionDefinitions,
   skillDefinitions: SkillDefinitions,
 ) {
   return {
-    ...tankToDuelMember(tank),
+    ...tankToDuelMember(tank, provisionDefinitions),
+
     crewSkills: createDefaultSkills(skillDefinitions),
     key: uniqueId(),
   } satisfies CompareMember;

src/core/blitzkrieg/tankToDuelMember.ts

@@ -1,22 +1,33 @@
 import { DuelMember } from '../../stores/duel';
 import { genericDefaultEquipmentMatrix } from '../../stores/duel/constants';
+import { availableProvisions } from './availableProvisions';
+import { ProvisionDefinitions } from './provisionDefinitions';
 import { TankDefinition } from './tankDefinitions';
 
-export function tankToDuelMember(tank: TankDefinition) {
+export function tankToDuelMember(
+  tank: TankDefinition,
+  provisionDefinitions: ProvisionDefinitions,
+) {
+  const turret = tank.turrets.at(-1)!;
+  const gun = turret.guns.at(-1)!;
+  const provisionsList = availableProvisions(tank, gun, provisionDefinitions);
+
   return {
     camouflage: true,
     consumables: [],
     equipmentMatrix: genericDefaultEquipmentMatrix,
     cooldownBooster: 0,
     crewMastery: 1,
-    provisions: [],
+    provisions: provisionsList
+      .filter((provision) => provision.crew !== undefined)
+      .map((provision) => provision.id),
     engine: tank.engines.at(-1)!,
-    gun: tank.turrets.at(-1)!.guns.at(-1)!,
+    gun,
     shell: tank.turrets.at(-1)!.guns.at(-1)!.shells[0],
     tank,
     track: tank.tracks.at(-1)!,
     yaw: 0,
     pitch: 0,
-    turret: tank.turrets.at(-1)!,
+    turret,
   } satisfies DuelMember;
 }