feat: used dahses for command readibility

src/core/discord/addPeriodSubCommands.ts

@@ -4,7 +4,8 @@ import {
 } from 'discord.js';
 import { PERIOD_NAMES } from '../discord/resolvePeriodFromCommand';
 
-export type Period = 'period' | 'customperiod';
+export type PeriodSubcommand = 'period' | 'custom';
+export type PeriodOption = `${number}` | 'career';
 
 export default function addPeriodSubCommands(
   option: SlashCommandSubcommandGroupBuilder,
@@ -16,18 +17,18 @@ export default function addPeriodSubCommands(
     .addSubcommand((option) =>
       extra(
         option
-          .setName('period' satisfies Period)
+          .setName('period' satisfies PeriodSubcommand)
           .setDescription(PERIOD_NAMES.period)
           .addStringOption((option) =>
             option
-              .setName('days')
+              .setName('period')
               .setDescription('A preset period')
               .setChoices(
-                { name: 'Today', value: '1' },
-                { name: '30 days', value: '30' },
-                { name: '60 days', value: '60' },
-                { name: '90 days', value: '90' },
-                { name: 'Career', value: 'Infinity' },
+                { name: 'Today', value: '1' satisfies PeriodOption },
+                { name: '30 days', value: '30' satisfies PeriodOption },
+                { name: '60 days', value: '60' satisfies PeriodOption },
+                { name: '90 days', value: '90' satisfies PeriodOption },
+                { name: 'Career', value: 'career' satisfies PeriodOption },
               )
               .setRequired(true),
           ),
@@ -36,8 +37,8 @@ export default function addPeriodSubCommands(
     .addSubcommand((option) =>
       extra(
         option
-          .setName('customperiod' satisfies Period)
-          .setDescription(PERIOD_NAMES.customperiod)
+          .setName('custom' satisfies PeriodSubcommand)
+          .setDescription(PERIOD_NAMES.custom)
           .addIntegerOption((option) =>
             option
               .setName('start')

src/core/discord/addStatTypeSubCommandGroups.ts

@@ -43,7 +43,7 @@ export default async function addStatTypeSubCommandGroups(
           })
           .addStringOption((option) =>
             option
-              .setName('tanktype')
+              .setName('tank-type')
               .setDescription('Type')
               .addChoices(
                 ...Object.entries(awaitedTankopediaInfo.vehicle_types).map(
@@ -65,7 +65,7 @@ export default async function addStatTypeSubCommandGroups(
           )
           .addStringOption((option) =>
             option
-              .setName('treetype')
+              .setName('tree-type')
               .setDescription('Tech tree type')
               .addChoices(
                 { name: 'Tech Tree', value: 'techtree' },
@@ -75,7 +75,7 @@ export default async function addStatTypeSubCommandGroups(
               .setRequired(false),
           ),
       )
-        .setName('tanks')
+        .setName('multi-tank')
         .setDescription('Multiple tanks'),
     );
 }

src/core/discord/resolvePeriodFromCommand.ts

@@ -3,20 +3,16 @@ import { Region } from '../../constants/regions';
 import getPeriodNow from '../blitzstars/getPeriodNow';
 import getPeriodStart from '../blitzstars/getPeriodStart';
 import getTimeDaysAgo from '../blitzstars/getTimeDaysAgo';
-import { Period } from '../discord/addPeriodSubCommands';
+import { PeriodSubcommand } from '../discord/addPeriodSubCommands';
 
-export const PERIOD_NAMES: Record<Period, string> = {
-  today: "Today's statistics",
-  period: "Set number of days' statistics",
-  career: 'Career statistics',
-  customperiod: 'Custom period',
+export const PERIOD_NAMES: Record<PeriodSubcommand, string> = {
+  period: "Preset period's statistics",
+  custom: "Custom period's statistics",
 };
 
-export const EVOLUTION_PERIOD_NAMES: Record<Period, string> = {
-  today: "Today's evolution",
-  period: "Set number of days' evolution",
-  career: 'Career evolution',
-  customperiod: 'Custom period',
+export const EVOLUTION_PERIOD_NAMES: Record<PeriodSubcommand, string> = {
+  period: "Preset period's evolution",
+  custom: "Custom period's evolution",
 };
 
 export interface ResolvedPeriod {
@@ -34,9 +30,9 @@ export default function resolvePeriodFromCommand(
   let evolutionName: string;
   let start: number;
   let end: number;
-  const period = interaction.options.getSubcommand() as Period;
+  const period = interaction.options.getSubcommand() as PeriodSubcommand;
 
-  if (period === 'customperiod') {
+  if (period === 'custom') {
     const startRaw = interaction.options.getInteger('start')!;
     const endRaw = interaction.options.getInteger('end')!;
     const startMin = Math.min(startRaw, endRaw);