From 99123b733d64aaf0233623821523f3f58f2c46ea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com>
Date: Wed, 10 Jan 2024 19:27:58 -0600
Subject: [PATCH] fix: hide on rotate

---
 .../tools/tankopedia/[id]/components/Model/TankDisplay.tsx | 7 +------
 .../[id]/components/Model/components/TankArmor.tsx         | 7 ++++++-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/app/tools/tankopedia/[id]/components/Model/TankDisplay.tsx b/src/app/tools/tankopedia/[id]/components/Model/TankDisplay.tsx
index b9c2b711f..1c729cdb9 100644
--- a/src/app/tools/tankopedia/[id]/components/Model/TankDisplay.tsx
+++ b/src/app/tools/tankopedia/[id]/components/Model/TankDisplay.tsx
@@ -42,7 +42,6 @@ export function TankDisplay() {
     if (!state.areTanksAssigned) return;
     return state.protagonist;
   });
-  const controlsEnabled = useTankopedia((state) => state.model.controlsEnabled);
 
   if (!protagonist) return null;
 
@@ -143,11 +142,7 @@ export function TankDisplay() {
                   }
                 >
                   <TankModel />
-                  {mode === 'armor' && (
-                    <group visible={controlsEnabled}>
-                      <TankArmor />
-                    </group>
-                  )}
+                  {mode === 'armor' && <TankArmor />}
                 </Suspense>
               </Canvas>
             </div>
diff --git a/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor.tsx b/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor.tsx
index 0dacd214c..36aa52f34 100644
--- a/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor.tsx
+++ b/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor.tsx
@@ -17,6 +17,7 @@ import { Lighting } from '../../Lighting';
 interface TankArmorProps extends GroupProps {}
 
 export function TankArmor({ ...props }: TankArmorProps) {
+  const controlsEnabled = useTankopedia((state) => state.model.controlsEnabled);
   const [awaitedModelDefinitions, setAwaitedModelDefinitions] = useState<
     ModelDefinitions | undefined
   >(undefined);
@@ -86,7 +87,11 @@ export function TankArmor({ ...props }: TankArmorProps) {
     <HeadsUpDisplay>
       <Lighting />
 
-      <group {...props} rotation={[-Math.PI / 2, 0, model.hullYaw]}>
+      <group
+        {...props}
+        rotation={[-Math.PI / 2, 0, model.hullYaw]}
+        visible={controlsEnabled}
+      >
         {nodes.map((node) => {
           const isHull = node.name.startsWith('hull_');
           const armorId = parseInt(node.name.match(/.+_armor_(\d+)/)![1]);