From 99cdf931a8bbf261ab068c2a4ec4ca910589579b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com> Date: Thu, 1 Aug 2024 14:16:42 -0500 Subject: [PATCH] fix: japanese gun depression --- src/core/blitz/applyPitchYawLimits.ts | 4 ++-- src/core/blitzkit/tankCharacteristics.ts | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/core/blitz/applyPitchYawLimits.ts b/src/core/blitz/applyPitchYawLimits.ts index f51cef659..639a9412d 100644 --- a/src/core/blitz/applyPitchYawLimits.ts +++ b/src/core/blitz/applyPitchYawLimits.ts @@ -19,8 +19,8 @@ export function applyPitchYawLimits( ); } - const depressionBuff = verticalStabilizer ? degToRad(4) : 0; - const elevationBuff = verticalStabilizer ? degToRad(3) : 0; + const depressionBuff = verticalStabilizer ? degToRad(3) : 0; + const elevationBuff = verticalStabilizer ? degToRad(4) : 0; let lowerPitch = -degToRad(pitchLimits.max) - depressionBuff; let upperPitch = -degToRad(pitchLimits.min) + elevationBuff; const transition = degToRad(pitchLimits.transition ?? 10); diff --git a/src/core/blitzkit/tankCharacteristics.ts b/src/core/blitzkit/tankCharacteristics.ts index 1eb36f5b4..6180572e4 100644 --- a/src/core/blitzkit/tankCharacteristics.ts +++ b/src/core/blitzkit/tankCharacteristics.ts @@ -5,7 +5,7 @@ import { resolvePenetrationCoefficient } from '../blitz/resolvePenetrationCoeffi import { coefficient } from './coefficient'; import { degressiveStat } from './degressiveStat'; import { EquipmentDefinitions } from './equipmentDefinitions'; -import { ModelDefinition, ModelDefinitions } from './modelDefinitions'; +import { ModelDefinition } from './modelDefinitions'; import { normalizeBoundingBox } from './normalizeBoundingBox'; import { progressiveStat } from './progressiveStat'; import { ProvisionDefinitions } from './provisionDefinitions'; @@ -75,7 +75,7 @@ export function tankCharacteristics( provisionDefinitions: ProvisionDefinitions; }, ) { - const presetRows = equipmentDefinitions.presets[tank.equipment]; + const presetRows = equipmentDefinitions.presets[tank.equipment]; const turretModelDefinition = tankModelDefinition.turrets[turret.id]; const gunModelDefinition = turretModelDefinition.guns[gun.id]; @@ -387,11 +387,11 @@ export function tankCharacteristics( const gunDepression = gunModelDefinition.pitch.max + gunDefaultPitch + - (hasImprovedVerticalStabilizer ? 4 : 0); + (hasImprovedVerticalStabilizer ? 3 : 0); const gunElevation = -gunModelDefinition.pitch.min - gunDefaultPitch + - (hasImprovedVerticalStabilizer ? 3 : 0); + (hasImprovedVerticalStabilizer ? 4 : 0); const gunFrontalDepression = gunModelDefinition.pitch.front?.max; const gunFrontalElevation = gunModelDefinition.pitch.front ? -gunModelDefinition.pitch.front.min