From b03589f6f09ba810ddddc33e36171de9156ce45f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com>
Date: Wed, 24 Jan 2024 14:57:37 -0600
Subject: [PATCH] fix: missing external modules

---
 .../TankArmor/components/ExternalModuleMask.tsx      | 12 ++++++------
 .../ArmorMesh/components/Armor/shaders/fragment.glsl |  4 +++-
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor/components/ExternalModuleMask.tsx b/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor/components/ExternalModuleMask.tsx
index 5b1d7a3ee..a490f7890 100644
--- a/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor/components/ExternalModuleMask.tsx
+++ b/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor/components/ExternalModuleMask.tsx
@@ -160,12 +160,12 @@ export const ExternalModuleMask = memo(() => {
           const isHull = node.name.startsWith('hull_');
           const isVisible = isHull;
           const armorId = nameToArmorId(node.name);
-          const { thickness } = resolveArmor(
+          const { thickness, spaced } = resolveArmor(
             tankModelDefinition.armor,
             armorId,
           );
 
-          if (!isVisible || thickness === undefined) return null;
+          if (!isVisible || thickness === undefined || spaced) return null;
 
           return (
             <ArmorMeshExternalModuleMask
@@ -202,12 +202,12 @@ export const ExternalModuleMask = memo(() => {
             );
             const isVisible = isCurrentTurret;
             const armorId = nameToArmorId(node.name);
-            const { thickness } = resolveArmor(
+            const { thickness, spaced } = resolveArmor(
               turretModelDefinition.armor,
               armorId,
             );
 
-            if (!isVisible || thickness === undefined) return null;
+            if (!isVisible || thickness === undefined || spaced) return null;
 
             return (
               <ArmorMeshExternalModuleMask
@@ -227,12 +227,12 @@ export const ExternalModuleMask = memo(() => {
             );
             const isVisible = isCurrentGun;
             const armorId = nameToArmorId(node.name);
-            const { thickness } = resolveArmor(
+            const { thickness, spaced } = resolveArmor(
               gunModelDefinition.armor,
               armorId,
             );
 
-            if (!isVisible || thickness === undefined) return null;
+            if (!isVisible || thickness === undefined || spaced) return null;
 
             return (
               <ArmorMeshExternalModuleMask
diff --git a/src/components/ArmorMesh/components/Armor/shaders/fragment.glsl b/src/components/ArmorMesh/components/Armor/shaders/fragment.glsl
index 25c1f37cb..5de0d8b37 100644
--- a/src/components/ArmorMesh/components/Armor/shaders/fragment.glsl
+++ b/src/components/ArmorMesh/components/Armor/shaders/fragment.glsl
@@ -113,5 +113,7 @@ void main() {
     gl_FragColor = vec4(color, (1.0 - penetrationChance) * 0.5);
   }
 
-  // gl_FragColor = externalModuleMaskColor;
+  // if (isUnderExternalModule) {
+  //   gl_FragColor = vec4(0.0, 0.0, 1.0, 1.0);
+  // }
 }
\ No newline at end of file