From bac2f097f21f99d422c3895220fdab133ea7e8a5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com>
Date: Sun, 1 Sep 2024 21:14:15 -0500
Subject: [PATCH] fix: add dialog titles

---
 src/app/tools/compare/components/Controls.tsx |  2 +
 .../tools/compare/components/TankControl.tsx  |  2 +
 src/app/tools/rating/page.tsx                 |  8 ++++
 .../Votes/components/VoteCaster.tsx           |  3 +-
 .../components/Model/MetaSection/index.tsx    |  2 +
 .../components/Model/components/Options.tsx   |  2 +
 .../tankopedia/[id]/components/Title.tsx      |  2 +
 .../components/WargamingLoginButton.tsx       | 42 +++++++++----------
 8 files changed, 39 insertions(+), 24 deletions(-)

diff --git a/src/app/tools/compare/components/Controls.tsx b/src/app/tools/compare/components/Controls.tsx
index 22d6a5464..4a8c52a4a 100644
--- a/src/app/tools/compare/components/Controls.tsx
+++ b/src/app/tools/compare/components/Controls.tsx
@@ -34,6 +34,8 @@ export function Controls({
         </Dialog.Trigger>
 
         <Dialog.Content>
+          <Dialog.Title align="center">Add tanks</Dialog.Title>
+
           <Flex gap="4" direction="column">
             <Flex
               direction="column"
diff --git a/src/app/tools/compare/components/TankControl.tsx b/src/app/tools/compare/components/TankControl.tsx
index 9076346f8..a97970acf 100644
--- a/src/app/tools/compare/components/TankControl.tsx
+++ b/src/app/tools/compare/components/TankControl.tsx
@@ -42,6 +42,8 @@ export function TankControl({ index, id }: TankControlProps) {
         </Dialog.Trigger>
 
         <Dialog.Content>
+          <Dialog.Title align="center">Switch tanks</Dialog.Title>
+
           <Flex gap="4" direction="column">
             <Flex
               direction="column"
diff --git a/src/app/tools/rating/page.tsx b/src/app/tools/rating/page.tsx
index 3979ca91d..2542baf95 100644
--- a/src/app/tools/rating/page.tsx
+++ b/src/app/tools/rating/page.tsx
@@ -607,6 +607,8 @@ export default function Page() {
             </Dialog.Trigger>
 
             <Dialog.Content>
+              <Dialog.Title>Jump to score</Dialog.Title>
+
               <Flex gap="4" justify="center">
                 <TextField.Root
                   ref={scoreInput}
@@ -640,6 +642,8 @@ export default function Page() {
             </Dialog.Trigger>
 
             <Dialog.Content>
+              <Dialog.Title>Jump to position</Dialog.Title>
+
               <Flex gap="4" justify="center">
                 <TextField.Root
                   ref={positionInput}
@@ -676,6 +680,8 @@ export default function Page() {
             </Dialog.Trigger>
 
             <Dialog.Content>
+              <Dialog.Title>Jump to league</Dialog.Title>
+
               <Flex gap="2" justify="center">
                 <Select.Root
                   value={`${jumpToLeague}`}
@@ -761,6 +767,8 @@ export default function Page() {
             </Dialog.Trigger>
 
             <Dialog.Content>
+              <Dialog.Title>Jump to player</Dialog.Title>
+
               <Flex gap="4" direction="column">
                 <TextField.Root
                   onChange={debounce(
diff --git a/src/app/tools/tankopedia/[id]/components/Model/MetaSection/components/Votes/components/VoteCaster.tsx b/src/app/tools/tankopedia/[id]/components/Model/MetaSection/components/Votes/components/VoteCaster.tsx
index d77258aa4..6b13d6e5d 100644
--- a/src/app/tools/tankopedia/[id]/components/Model/MetaSection/components/Votes/components/VoteCaster.tsx
+++ b/src/app/tools/tankopedia/[id]/components/Model/MetaSection/components/Votes/components/VoteCaster.tsx
@@ -4,7 +4,6 @@ import {
   Button,
   Dialog,
   Flex,
-  Heading,
   Spinner,
   Text,
 } from '@radix-ui/themes';
@@ -36,7 +35,7 @@ export function VoteCaster() {
         </Dialog.Trigger>
 
         <Dialog.Content maxWidth="23rem">
-          <Heading>Voting for {tank.name}</Heading>
+          <Dialog.Title>Voting for {tank.name}</Dialog.Title>
 
           <Flex direction="column" mt="4">
             <Flex align="center" justify="between">
diff --git a/src/app/tools/tankopedia/[id]/components/Model/MetaSection/index.tsx b/src/app/tools/tankopedia/[id]/components/Model/MetaSection/index.tsx
index 0ebee785a..25a172fe7 100644
--- a/src/app/tools/tankopedia/[id]/components/Model/MetaSection/index.tsx
+++ b/src/app/tools/tankopedia/[id]/components/Model/MetaSection/index.tsx
@@ -57,6 +57,8 @@ export function MetaSection() {
             </Dialog.Trigger>
 
             <Dialog.Content>
+              <Dialog.Title>Swap tanks</Dialog.Title>
+
               <TankSearch
                 compact
                 onSelect={(tank) => {
diff --git a/src/app/tools/tankopedia/[id]/components/Model/components/Options.tsx b/src/app/tools/tankopedia/[id]/components/Model/components/Options.tsx
index be3c28a3e..99c7f07fa 100644
--- a/src/app/tools/tankopedia/[id]/components/Model/components/Options.tsx
+++ b/src/app/tools/tankopedia/[id]/components/Model/components/Options.tsx
@@ -360,6 +360,8 @@ export function Options({ thicknessRange, canvas }: OptionsProps) {
               </Dialog.Trigger>
 
               <Dialog.Content>
+                <Dialog.Title align="center">Select tank</Dialog.Title>
+
                 <Tabs.Root
                   value={tab}
                   onValueChange={setTab}
diff --git a/src/app/tools/tankopedia/[id]/components/Title.tsx b/src/app/tools/tankopedia/[id]/components/Title.tsx
index 0615b829a..b6e0994dc 100644
--- a/src/app/tools/tankopedia/[id]/components/Title.tsx
+++ b/src/app/tools/tankopedia/[id]/components/Title.tsx
@@ -69,6 +69,8 @@ export function Title() {
             </Dialog.Trigger>
 
             <Dialog.Content>
+              <Dialog.Title align="center">Change tank</Dialog.Title>
+
               <Flex gap="4" direction="column">
                 <Flex
                   direction="column"
diff --git a/src/components/Navbar/components/WargamingLoginButton.tsx b/src/components/Navbar/components/WargamingLoginButton.tsx
index 95848c168..a5fc8764e 100644
--- a/src/components/Navbar/components/WargamingLoginButton.tsx
+++ b/src/components/Navbar/components/WargamingLoginButton.tsx
@@ -1,4 +1,4 @@
-import { Button, ButtonProps, Dialog, Flex, Text } from '@radix-ui/themes';
+import { Button, ButtonProps, Dialog, Flex } from '@radix-ui/themes';
 import { REGIONS } from '../../../constants/regions';
 import { WARGAMING_APPLICATION_ID } from '../../../constants/wargamingApplicationID';
 import { WargamingIcon } from '../../../icons/Wargaming';
@@ -21,28 +21,26 @@ export function WargamingLoginButton({ children, ...props }: ButtonProps) {
       </Dialog.Trigger>
 
       <Dialog.Content width="fit-content">
-        <Flex direction="column" gap="4" align="center">
-          <Text color="gray">Choose your region</Text>
+        <Dialog.Title align="center">Choose your region</Dialog.Title>
 
-          <Flex gap="2" wrap="wrap">
-            {REGIONS.map((region) => (
-              <Dialog.Close key={region}>
-                <Link
-                  href={
-                    typeof window !== 'undefined'
-                      ? `https://api.worldoftanks.${region}/wot/auth/login/?application_id=${WARGAMING_APPLICATION_ID}&redirect_uri=${encodeURIComponent(
-                          `${location.origin}/auth/wargaming?return=${location.origin}${location.pathname}`,
-                        )}`
-                      : undefined
-                  }
-                >
-                  <Button color="red">
-                    {strings.common.regions.normal[region]}
-                  </Button>
-                </Link>
-              </Dialog.Close>
-            ))}
-          </Flex>
+        <Flex gap="2" wrap="wrap">
+          {REGIONS.map((region) => (
+            <Dialog.Close key={region}>
+              <Link
+                href={
+                  typeof window !== 'undefined'
+                    ? `https://api.worldoftanks.${region}/wot/auth/login/?application_id=${WARGAMING_APPLICATION_ID}&redirect_uri=${encodeURIComponent(
+                        `${location.origin}/auth/wargaming?return=${location.origin}${location.pathname}`,
+                      )}`
+                    : undefined
+                }
+              >
+                <Button color="red">
+                  {strings.common.regions.normal[region]}
+                </Button>
+              </Link>
+            </Dialog.Close>
+          ))}
         </Flex>
       </Dialog.Content>
     </Dialog.Root>