feat: simplified no ongoing ratings season

src/commands/ratings.tsx

@@ -20,6 +20,7 @@ import getMidnightLeaderboard, {
 import addRegionChoices from '../core/discord/addRegionChoices';
 import addUsernameChoices from '../core/discord/addUsernameChoices';
 import autocompleteUsername from '../core/discord/autocompleteUsername';
+import embedNegative from '../core/discord/embedNegative';
 import resolvePlayerFromCommand from '../core/discord/resolvePlayerFromCommand';
 import { octokit } from '../core/github/octokit';
 import throwError from '../core/node/throwError';
@@ -172,6 +173,11 @@ function addSubcommands(
     );
 }
 
+const noOngoingSeason = embedNegative(
+  'No ongoing season',
+  "Wargaming didn't provide any data for this season.",
+);
+
 export const ratingsCommand = new Promise<CommandRegistryRaw>(
   async (resolve) => {
     const seasonChoices = await octokit.repos
@@ -259,10 +265,12 @@ export const ratingsCommand = new Promise<CommandRegistryRaw>(
           regionRatingsInfo = await (subcommandGroup === 'current'
             ? getRatingsInfo(region)
             : getArchivedRatingsInfo(season!, region));
+
+          if (regionRatingsInfo.detail !== undefined) return noOngoingSeason;
+
           const regionSubdomain = regionToRegionSubdomain(region);
           const result =
             subcommandGroup === 'current'
-              ? regionRatingsInfo.detail === undefined
               ? await fetch(
                   `https://${regionSubdomain}.wotblitz.com/en/api/rating-leaderboards/league/${leagueIndex}/top/`,
                 )
@@ -279,7 +287,6 @@ export const ratingsCommand = new Promise<CommandRegistryRaw>(
                         }) satisfies SimplifiedPlayer,
                     ),
                   )
-                : undefined
               : await octokit.repos
                   .getContent({
                     ...DATABASE_REPO,
@@ -323,34 +330,25 @@ export const ratingsCommand = new Promise<CommandRegistryRaw>(
                         }) satisfies SimplifiedPlayer,
                     );
                   });
-          const leagueInfo =
+          const leagueInfo = regionRatingsInfo.leagues[leagueIndex];
-            regionRatingsInfo.detail === undefined
-              ? regionRatingsInfo.leagues[leagueIndex]
-              : undefined;
           midnightLeaderboard =
             subcommandGroup === 'current'
-              ? regionRatingsInfo.detail === undefined
               ? await getMidnightLeaderboard(
                   region,
                   regionRatingsInfo.current_season,
                 )
-                : undefined
               : await getMidnightLeaderboard(region, season!);
 
           players = result;
           playersBefore = result ? result[0].position - 1 : 0;
           playersAfter =
-            regionRatingsInfo.detail === undefined && result !== undefined
+            regionRatingsInfo.count - result[result.length - 1].position;
-              ? regionRatingsInfo.count - result[result.length - 1].position
-              : 0;
           titleName = `${
             leagueInfo ? leagueInfo.title : 'No Ongoing Season'
           } - ${REGION_NAMES_SHORT[region]}`;
-          titleImage = leagueInfo
+          titleImage = leagueInfo.big_icon.startsWith('http')
-            ? leagueInfo.big_icon.startsWith('http')
             ? leagueInfo.big_icon
-              : `https:${leagueInfo.big_icon}`
+            : `https:${leagueInfo.big_icon}`;
-            : undefined;
           titleDescription = `Top ${limit} players`;
         } else {
           const { region, id } = await resolvePlayerFromCommand(interaction);
@@ -372,6 +370,9 @@ export const ratingsCommand = new Promise<CommandRegistryRaw>(
                       response.json(),
                     )) as RatingsInfo;
                   });
+
+          if (regionRatingsInfo.detail !== undefined) return noOngoingSeason;
+
           const accountInfo = await getWargamingResponse<AccountInfo>(
             `https://api.wotblitz.${region}/wotb/account/info/?application_id=${WARGAMING_APPLICATION_ID}&account_id=${id}`,
           );
@@ -383,15 +384,13 @@ export const ratingsCommand = new Promise<CommandRegistryRaw>(
           const regionSubdomain = regionToRegionSubdomain(region);
           const neighbors =
             subcommandGroup === 'current'
-              ? regionRatingsInfo.detail === undefined
               ? await fetch(
                   `https://${regionSubdomain}.wotblitz.com/en/api/rating-leaderboards/user/${id}/?neighbors=${Math.round(
                     limit / 2,
                   )}`,
                 )
                   .then(
-                      (response) =>
+                    (response) => response.json() as Promise<RatingsNeighbors>,
-                        response.json() as Promise<RatingsNeighbors>,
                   )
                   .then((players) =>
                     players.neighbors.map(
@@ -405,7 +404,6 @@ export const ratingsCommand = new Promise<CommandRegistryRaw>(
                         }) satisfies SimplifiedPlayer,
                     ),
                   )
-                : undefined
               : await octokit.repos
                   .getContent({
                     ...DATABASE_REPO,
@@ -453,21 +451,17 @@ export const ratingsCommand = new Promise<CommandRegistryRaw>(
                   });
           midnightLeaderboard =
             subcommandGroup === 'current'
-              ? regionRatingsInfo.detail === undefined
               ? await getMidnightLeaderboard(
                   region,
                   regionRatingsInfo.current_season,
                 )
-                : undefined
               : await getMidnightLeaderboard(region, season!);
 
           if (clan && neighbors) titleNameDiscriminator = `[${clan.tag}]`;
 
           players = neighbors;
-          titleImage = neighbors
+          titleImage = clan
-            ? clan
             ? `https://wotblitz-gc.gcdn.co/icons/clanEmblems1x/clan-icon-v2-${clan.emblem_set_id}.png`
-              : undefined
             : undefined;
           titleName = neighbors
             ? accountInfo[id].nickname
@@ -475,24 +469,20 @@ export const ratingsCommand = new Promise<CommandRegistryRaw>(
           titleDescription = 'Ratings neighbours';
           playersBefore = neighbors ? neighbors[0].position - 1 : 0;
           playersAfter =
-            regionRatingsInfo.detail === undefined
+            regionRatingsInfo.count - neighbors[neighbors.length - 1].position;
-              ? neighbors
-                ? regionRatingsInfo.count -
-                  neighbors[neighbors.length - 1].position
-                : 0
-              : 0;
           playerId = id;
         }
 
-        const items = players?.map((player) => {
+        const resolvedRegionRatingsInfo: typeof regionRatingsInfo & {
-          const reward =
+          detail: undefined;
-            regionRatingsInfo.detail === undefined
+        } = regionRatingsInfo;
-              ? regionRatingsInfo.rewards.find(
+
+        const items = players.map((player) => {
+          const reward = resolvedRegionRatingsInfo.rewards.find(
             (reward) =>
               player.position >= reward.from_position &&
               player.position <= reward.to_position,
-                )
+          );
-              : undefined;
           const midnightIndex = midnightLeaderboard?.findIndex(
             (item) => item.id === player.id,
           );