fix: a drew redundancies

src/commands/breakdown.tsx

@@ -7,9 +7,11 @@ import Wrapper from '../components/Wrapper';
 import { AllStats, getAccountInfo } from '../core/blitz/getAccountInfo';
 import { getClanAccountInfo } from '../core/blitz/getClanAccountInfo';
 import getTankStats from '../core/blitz/getTankStats';
-import getTreeType from '../core/blitz/getTreeType';
 import { filtersToDescription } from '../core/blitzkrieg/filtersToDescription';
-import { tankDefinitions } from '../core/blitzkrieg/tankDefinitions';
+import {
+  TankDefinition,
+  tankDefinitions,
+} from '../core/blitzkrieg/tankDefinitions';
 import { getBlitzStarsLinkButton } from '../core/blitzstars/getBlitzStarsLinkButton';
 import getStatsInPeriod from '../core/blitzstars/getStatsInPeriod';
 import { tankAverages } from '../core/blitzstars/tankAverages';
@@ -36,7 +38,7 @@ import getWN8Percentile from '../core/statistics/getWN8Percentile';
 import { CommandRegistryPromisable } from '../events/interactionCreate';
 
 const ROWS_PER_PAGE = 8;
-const MAX_PAGES = 10;
+const MAX_PAGES = 9;
 
 export async function renderBreakdown(
   { region, id }: ResolvedPlayer,
@@ -180,9 +182,10 @@ export async function renderBreakdown(
       />,
     );
 
-    await Promise.all(
+    filteredOrder.forEach((id, index) => {
-      filteredOrder.map(async (id, index) => {
+      const tankDefinition = awaitedTankDefinitions[id] as
-        const tankDefinition = awaitedTankDefinitions[id];
+        | TankDefinition
+        | undefined;
       const current = orderedCurrentStats[index];
       const career = orderedCareerStats[index];
       const currentWN8 = orderedCurrentWN8[index];
@@ -193,8 +196,8 @@ export async function renderBreakdown(
           key={id}
           type="tank"
           tankType={tankDefinition?.type}
-            treeType={tankDefinition ? await getTreeType(id) : undefined}
+          treeType={tankDefinition?.treeType}
-            title={awaitedTankDefinitions[id].name}
+          title={tankDefinition?.name ?? `Unknown tank ${id}`}
           stats={[
             {
               title: 'Battles',
@@ -240,8 +243,7 @@ export async function renderBreakdown(
           ]}
         />,
       );
-      }),
+    });
-    );
   }
 
   const pages = chunk(
@@ -282,9 +284,7 @@ export async function renderBreakdown(
           description={`${name} • ${filterDescriptions}`}
         />
 
-        {filteredOrder.length === 0 && (
         <NoData type={NoDataType.BattlesInPeriod} />
-        )}
       </Wrapper>,
     ];
   }

src/core/blitz/getTreeType.ts

@@ -1,11 +0,0 @@
-import { TreeType } from '../../components/Tanks';
-import { tankDefinitions } from '../blitzkrieg/tankDefinitions';
-
-export default async function getTreeType(id: number): Promise<TreeType> {
-  const entry = (await tankDefinitions)[id];
-
-  if (entry.treeType === 'collector') return 'collector';
-  if (entry.treeType === 'premium') return 'premium';
-
-  return 'researchable';
-}