From 6153beced6fa8d0754b9d48c3e65cfc418f7319a Mon Sep 17 00:00:00 2001 From: Mark Greene Date: Sun, 4 Oct 2026 14:24:02 +1300 Subject: [PATCH 1/2] Fix: search redirecting early and missing full tank names **Enter key** - Enter redirected to the previous results' first tank while a search was still buffering, because the key handler captured a stale `searching` value. - Enter on an empty field redirected to the first tank of the unfiltered list (Sheridan). - The handler now reads live filter state and only acts when there is a settled search, matching the quick-link button. **Full names in search** - Search only knew short tank names, so queries like "super pershing" found nothing when the game stores a short form. - Add an optional `name_full` to `TankDefinition`, filled from the game's full name when a short name exists, and index it (plus an accent-stripped copy) in `fetchTankNames` / `SEARCH_KEYS`. - Displayed names are unchanged. Full names become searchable once the definitions are regenerated on the next build. --- .../blitzkit/api/server/1_tankDefinitions.ts | 3 +++ packages/core/src/blitzkit/tankNames.ts | 13 ++++++++++++ .../core/src/protos/tank_definitions.proto | 1 + packages/core/src/protos/tank_definitions.ts | 20 +++++++++++++++++++ .../TankSearch/components/SearchBar.tsx | 3 ++- 5 files changed, 39 insertions(+), 1 deletion(-) diff --git a/packages/core/src/blitzkit/api/server/1_tankDefinitions.ts b/packages/core/src/blitzkit/api/server/1_tankDefinitions.ts index ee3f69a58..b7ff54c8d 100644 --- a/packages/core/src/blitzkit/api/server/1_tankDefinitions.ts +++ b/packages/core/src/blitzkit/api/server/1_tankDefinitions.ts @@ -371,6 +371,9 @@ export abstract class ServerBlitzKitAPI1 extends ServerBlitzKitAPI0 { (tank.shortUserString ? this.getString(tank.shortUserString) : undefined) ?? this.getString(tank.userString), + name_full: tank.shortUserString + ? this.getString(tank.userString) + : undefined, slug, nation, type: tankTags.includes("collectible") diff --git a/packages/core/src/blitzkit/tankNames.ts b/packages/core/src/blitzkit/tankNames.ts index bb19c9597..15462add5 100644 --- a/packages/core/src/blitzkit/tankNames.ts +++ b/packages/core/src/blitzkit/tankNames.ts @@ -18,11 +18,22 @@ export async function fetchTankNames(api: BlitzKitAPI) { searchableNameDeburr.locales[key] = deburr(value); }); + const searchableNameFull: I18nString = { + locales: { ...tank.name_full?.locales }, + }; + const searchableNameFullDeburr: I18nString = { locales: {} }; + + Object.entries(searchableNameFull.locales).forEach(([key, value]) => { + searchableNameFullDeburr.locales[key] = deburr(value); + }); + return { id: tank.id, name: tank.name, searchableName: tank.name, searchableNameDeburr, + searchableNameFull, + searchableNameFullDeburr, camouflages: tank.camouflages ?.map((id) => locales.supported.map( @@ -45,6 +56,8 @@ export const SEARCH_KEYS = [ .map(({ locale }) => [ `searchableName.locales.${locale}`, `searchableNameDeburr.locales.${locale}`, + `searchableNameFull.locales.${locale}`, + `searchableNameFullDeburr.locales.${locale}`, ]) .flat(), "camouflages", diff --git a/packages/core/src/protos/tank_definitions.proto b/packages/core/src/protos/tank_definitions.proto index 0c15d59f1..6c9cb1078 100644 --- a/packages/core/src/protos/tank_definitions.proto +++ b/packages/core/src/protos/tank_definitions.proto @@ -41,6 +41,7 @@ message TankDefinition { required uint32 weight = 31; required string dev_name = 32; optional Equalizer equalizer = 33; + optional I18nString name_full = 34; } message Equalizer { diff --git a/packages/core/src/protos/tank_definitions.ts b/packages/core/src/protos/tank_definitions.ts index 302424353..be6e2a1f0 100644 --- a/packages/core/src/protos/tank_definitions.ts +++ b/packages/core/src/protos/tank_definitions.ts @@ -292,6 +292,7 @@ export interface TankDefinition { weight: number; dev_name: string; equalizer?: Equalizer | undefined; + name_full?: I18nString | undefined; } export interface TankDefinition_RolesEntry { @@ -651,6 +652,7 @@ function createBaseTankDefinition(): TankDefinition { weight: 0, dev_name: "", equalizer: undefined, + name_full: undefined, }; } @@ -752,6 +754,9 @@ export const TankDefinition: MessageFns = { if (message.equalizer !== undefined) { Equalizer.encode(message.equalizer, writer.uint32(266).fork()).join(); } + if (message.name_full !== undefined) { + I18nString.encode(message.name_full, writer.uint32(274).fork()).join(); + } return writer; }, @@ -1051,6 +1056,14 @@ export const TankDefinition: MessageFns = { message.equalizer = Equalizer.decode(reader, reader.uint32()); continue; } + case 34: { + if (tag !== 274) { + break; + } + + message.name_full = I18nString.decode(reader, reader.uint32()); + continue; + } } if ((tag & 7) === 4 || tag === 0) { break; @@ -1111,6 +1124,7 @@ export const TankDefinition: MessageFns = { weight: isSet(object.weight) ? globalThis.Number(object.weight) : 0, dev_name: isSet(object.dev_name) ? globalThis.String(object.dev_name) : "", equalizer: isSet(object.equalizer) ? Equalizer.fromJSON(object.equalizer) : undefined, + name_full: isSet(object.name_full) ? I18nString.fromJSON(object.name_full) : undefined, }; }, @@ -1218,6 +1232,9 @@ export const TankDefinition: MessageFns = { if (message.equalizer !== undefined) { obj.equalizer = Equalizer.toJSON(message.equalizer); } + if (message.name_full !== undefined) { + obj.name_full = I18nString.toJSON(message.name_full); + } return obj; }, @@ -1271,6 +1288,9 @@ export const TankDefinition: MessageFns = { message.equalizer = (object.equalizer !== undefined && object.equalizer !== null) ? Equalizer.fromPartial(object.equalizer) : undefined; + message.name_full = (object.name_full !== undefined && object.name_full !== null) + ? I18nString.fromPartial(object.name_full) + : undefined; return message; }, }; diff --git a/packages/website/src/components/TankSearch/components/SearchBar.tsx b/packages/website/src/components/TankSearch/components/SearchBar.tsx index 32eba599f..1a97aa3d2 100644 --- a/packages/website/src/components/TankSearch/components/SearchBar.tsx +++ b/packages/website/src/components/TankSearch/components/SearchBar.tsx @@ -46,7 +46,8 @@ export function SearchBar({ topResult, skeleton, onSelect }: SearchBarProps) { }, [searching]); const handleKeyDown = useCallback( (event) => { - if (event.key !== "Enter" || !topResult || searching) return; + if (event.key !== "Enter" || !topResult) return; + if (!TankFilters.state.search || TankFilters.state.searching) return; event.preventDefault(); From f3a8f2faab21c0423d8c229b3e3ed1b2f165678f Mon Sep 17 00:00:00 2001 From: tresabhi <43380238+tresabhi@users.noreply.github.com> Date: Sun, 4 Oct 2026 14:03:32 -0500 Subject: [PATCH 2/2] only supply full name if it's different --- .../blitzkit/api/server/1_tankDefinitions.ts | 18 +++++++++++------- .../TankSearch/components/SearchBar.tsx | 14 ++++++++++---- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/packages/core/src/blitzkit/api/server/1_tankDefinitions.ts b/packages/core/src/blitzkit/api/server/1_tankDefinitions.ts index b7ff54c8d..e7192e140 100644 --- a/packages/core/src/blitzkit/api/server/1_tankDefinitions.ts +++ b/packages/core/src/blitzkit/api/server/1_tankDefinitions.ts @@ -350,6 +350,15 @@ export abstract class ServerBlitzKitAPI1 extends ServerBlitzKitAPI0 { const tankClass = this.blitzTankClassToBlitzkit[blitzTankClass as BlitzTankClass]; + const canonicalFullName = this.getString(tank.userString); + const name = + (tank.shortUserString + ? this.getString(tank.shortUserString) + : undefined) ?? canonicalFullName; + // only supply full name if it's different from the displayed short name to save some bytes + const name_full = + name === canonicalFullName ? undefined : canonicalFullName; + tankDefinitions.tanks[tankId] = { ancestors: [], successors: [], @@ -367,13 +376,8 @@ export abstract class ServerBlitzKitAPI1 extends ServerBlitzKitAPI0 { typeof equipment === "string" ? equipment : equipment.at(-1)!, max_consumables: tankDefinition.root.consumableSlots, max_provisions: tankDefinition.root.provisionSlots, - name: - (tank.shortUserString - ? this.getString(tank.shortUserString) - : undefined) ?? this.getString(tank.userString), - name_full: tank.shortUserString - ? this.getString(tank.userString) - : undefined, + name, + name_full, slug, nation, type: tankTags.includes("collectible") diff --git a/packages/website/src/components/TankSearch/components/SearchBar.tsx b/packages/website/src/components/TankSearch/components/SearchBar.tsx index 1a97aa3d2..034a2e458 100644 --- a/packages/website/src/components/TankSearch/components/SearchBar.tsx +++ b/packages/website/src/components/TankSearch/components/SearchBar.tsx @@ -33,7 +33,7 @@ export function SearchBar({ topResult, skeleton, onSelect }: SearchBarProps) { draft.search = sanitized.length === 0 ? null : sanitized; }); }, 500), - [] + [], ); const handleChange = useCallback(() => { if (!searching) { @@ -46,8 +46,14 @@ export function SearchBar({ topResult, skeleton, onSelect }: SearchBarProps) { }, [searching]); const handleKeyDown = useCallback( (event) => { - if (event.key !== "Enter" || !topResult) return; - if (!TankFilters.state.search || TankFilters.state.searching) return; + if ( + event.key !== "Enter" || + !topResult || + !TankFilters.state.search || + TankFilters.state.searching + ) { + return; + } event.preventDefault(); @@ -57,7 +63,7 @@ export function SearchBar({ topResult, skeleton, onSelect }: SearchBarProps) { window.location.href = `/tanks/${topResult.slug}`; } }, - [topResult] + [topResult], ); return (