From f9d0659bd4d977209e7d066c2a66ff065d879331 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com>
Date: Wed, 10 Jan 2024 17:29:49 -0600
Subject: [PATCH] feat: opaque amror

---
 .vscode/settings.json                         |  1 +
 .../[id]/components/Model/TankDisplay.tsx     | 54 ++++++++++++++-----
 .../components/Model/components/TankArmor.tsx |  3 ++
 src/components/ArmorMesh/index.tsx            | 13 +++--
 .../ArmorMesh/shaders/fragment.glsl           | 16 +++---
 .../ArmorMesh/shaders/fragmentOpaque.glsl     | 52 ++++++++++++++++++
 src/components/ArmorMesh/shaders/vertex.glsl  |  6 +--
 src/stores/tankopedia.ts                      |  2 +
 8 files changed, 119 insertions(+), 28 deletions(-)
 create mode 100644 src/components/ArmorMesh/shaders/fragmentOpaque.glsl

diff --git a/.vscode/settings.json b/.vscode/settings.json
index 0ca7d3e4e..eed8bbe76 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -37,6 +37,7 @@
     "fullstats",
     "fuzzysort",
     "gamemode",
+    "glsl",
     "GLTF",
     "immer",
     "JOINTINDEX",
diff --git a/src/app/tools/tankopedia/[id]/components/Model/TankDisplay.tsx b/src/app/tools/tankopedia/[id]/components/Model/TankDisplay.tsx
index 73183d7de..d9d8e5076 100644
--- a/src/app/tools/tankopedia/[id]/components/Model/TankDisplay.tsx
+++ b/src/app/tools/tankopedia/[id]/components/Model/TankDisplay.tsx
@@ -1,9 +1,16 @@
 import {
   EnterFullScreenIcon,
   ExitFullScreenIcon,
-  FrameIcon,
+  GearIcon,
 } from '@radix-ui/react-icons';
-import { Button, Card, Flex, Tabs, Theme } from '@radix-ui/themes';
+import {
+  Button,
+  Card,
+  DropdownMenu,
+  Flex,
+  Tabs,
+  Theme,
+} from '@radix-ui/themes';
 import { Html } from '@react-three/drei';
 import { Canvas } from '@react-three/fiber';
 import { Suspense, use, useEffect, useRef, useState } from 'react';
@@ -29,6 +36,7 @@ export function TankDisplay() {
   const [isFullScreen, setIsFullScreen] = useState(false);
   const mode = useTankopedia((state) => state.mode);
   const showGrid = useTankopedia((state) => state.model.showGrid);
+  const opaqueArmor = useTankopedia((state) => state.model.opaqueArmor);
   const protagonist = useTankopedia((state) => {
     if (!state.areTanksAssigned) return;
     return state.protagonist;
@@ -147,17 +155,37 @@ export function TankDisplay() {
                 right: 18,
               }}
             >
-              <Button
-                color={showGrid ? 'purple' : 'gray'}
-                variant="ghost"
-                onClick={() => {
-                  mutateTankopedia((draft) => {
-                    draft.model.showGrid = !draft.model.showGrid;
-                  });
-                }}
-              >
-                <FrameIcon />
-              </Button>
+              <DropdownMenu.Root>
+                <DropdownMenu.Trigger>
+                  <Button color={showGrid ? 'purple' : 'gray'} variant="ghost">
+                    <GearIcon />
+                  </Button>
+                </DropdownMenu.Trigger>
+
+                <DropdownMenu.Content>
+                  <DropdownMenu.CheckboxItem
+                    checked={showGrid}
+                    onCheckedChange={(checked) => {
+                      mutateTankopedia((draft) => {
+                        draft.model.showGrid = checked;
+                      });
+                    }}
+                  >
+                    Show grid
+                  </DropdownMenu.CheckboxItem>
+
+                  <DropdownMenu.CheckboxItem
+                    checked={opaqueArmor}
+                    onCheckedChange={(checked) => {
+                      mutateTankopedia((draft) => {
+                        draft.model.opaqueArmor = checked;
+                      });
+                    }}
+                  >
+                    Opaque armor
+                  </DropdownMenu.CheckboxItem>
+                </DropdownMenu.Content>
+              </DropdownMenu.Root>
 
               <Button
                 variant="ghost"
diff --git a/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor.tsx b/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor.tsx
index ff063f71a..e8613130f 100644
--- a/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor.tsx
+++ b/src/app/tools/tankopedia/[id]/components/Model/components/TankArmor.tsx
@@ -11,6 +11,7 @@ import {
   modelDefinitions,
 } from '../../../../../../../core/blitzkrieg/modelDefinitions';
 import { useTankopedia } from '../../../../../../../stores/tankopedia';
+import { Lighting } from '../../Lighting';
 
 interface TankArmorProps extends GroupProps {}
 
@@ -81,6 +82,8 @@ export function TankArmor(props: TankArmorProps) {
 
   return (
     <HeadsUpDisplay>
+      <Lighting />
+
       <group {...props} rotation={[-Math.PI / 2, 0, model.hullYaw]}>
         {nodes.map((node) => {
           const isHull = node.name.startsWith('hull_');
diff --git a/src/components/ArmorMesh/index.tsx b/src/components/ArmorMesh/index.tsx
index 0f94ccb61..67be3443c 100644
--- a/src/components/ArmorMesh/index.tsx
+++ b/src/components/ArmorMesh/index.tsx
@@ -1,7 +1,9 @@
 import { MeshProps } from '@react-three/fiber';
-import { MeshBasicMaterial } from 'three';
+import { MeshStandardMaterial } from 'three';
 import CustomShaderMaterial from 'three-custom-shader-material';
+import { useTankopedia } from '../../stores/tankopedia';
 import fragment from './shaders/fragment.glsl';
+import fragmentOpaque from './shaders/fragmentOpaque.glsl';
 import vertex from './shaders/vertex.glsl';
 
 interface ArmorMeshProps extends MeshProps {
@@ -20,6 +22,8 @@ export function ArmorMesh({
   normalization,
   ...props
 }: ArmorMeshProps) {
+  const opaqueArmor = useTankopedia((state) => state.model.opaqueArmor);
+
   return (
     <>
       <mesh {...props}>
@@ -28,10 +32,10 @@ export function ArmorMesh({
 
       <mesh {...props} renderOrder={1}>
         <CustomShaderMaterial
-          baseMaterial={MeshBasicMaterial}
+          baseMaterial={MeshStandardMaterial}
           transparent
           silent
-          depthWrite={false}
+          // depthWrite={false}
           uniforms={{
             thickness: { value: thickness },
             penetration: { value: penetration },
@@ -40,7 +44,8 @@ export function ArmorMesh({
             normalization: { value: normalization * (Math.PI / 180) },
           }}
           vertexShader={vertex}
-          fragmentShader={fragment}
+          // split shaders due to https://github.com/FarazzShaikh/THREE-CustomShaderMaterial/issues/48
+          fragmentShader={opaqueArmor ? fragmentOpaque : fragment}
         />
       </mesh>
     </>
diff --git a/src/components/ArmorMesh/shaders/fragment.glsl b/src/components/ArmorMesh/shaders/fragment.glsl
index b34232105..83fa201bf 100644
--- a/src/components/ArmorMesh/shaders/fragment.glsl
+++ b/src/components/ArmorMesh/shaders/fragment.glsl
@@ -1,4 +1,6 @@
-varying vec3 vViewPosition;
+// split shaders due to https://github.com/FarazzShaikh/THREE-CustomShaderMaterial/issues/48
+
+varying vec3 vCSMViewPosition;
 uniform float thickness;
 uniform float penetration;
 uniform float ricochet;
@@ -7,7 +9,7 @@ uniform float normalization;
 
 void main() {
   vec3 normalizedNormal = normalize(vNormal);
-  vec3 normalizedViewPosition = normalize(vViewPosition);
+  vec3 normalizedViewPosition = normalize(vCSMViewPosition);
   float cosAngle = dot(normalizedNormal, -normalizedViewPosition);
   float angle = acos(cosAngle);
 
@@ -18,18 +20,18 @@ void main() {
   float finalPenetration = penetration;
   float effectiveArmor = thickness / cos(angle - finalNormalization);
 
-  if(angle < ricochet) {
+  if (angle < ricochet) {
     // no auto-ricochet, resume checks
-    if(threeCaliberRule) {
+    if (threeCaliberRule) {
       penetrationChance = 1.0;
     } else {
       float maxRandomPenetrationBuff = finalPenetration * 0.05;
       float penetrationDifference = effectiveArmor - finalPenetration;
 
-      if(penetrationDifference > maxRandomPenetrationBuff) {
+      if (penetrationDifference > maxRandomPenetrationBuff) {
         // even with a +5% buff, can't penetrate
         penetrationChance = 0.0;
-      } else if(penetrationDifference < -maxRandomPenetrationBuff) {
+      } else if (penetrationDifference < -maxRandomPenetrationBuff) {
         // event with a -5% nerf, can penetrate
         penetrationChance = 1.0;
       } else {
@@ -39,5 +41,5 @@ void main() {
     }
   }
 
-  csm_FragColor *= vec4(1.0, 0.0, 0.0, (1.0 - penetrationChance) * 0.5);
+  csm_FragColor = vec4(1.0, 0.0, 0.0, (1.0 - penetrationChance) * 0.5);
 }
\ No newline at end of file
diff --git a/src/components/ArmorMesh/shaders/fragmentOpaque.glsl b/src/components/ArmorMesh/shaders/fragmentOpaque.glsl
new file mode 100644
index 000000000..d1a9b1499
--- /dev/null
+++ b/src/components/ArmorMesh/shaders/fragmentOpaque.glsl
@@ -0,0 +1,52 @@
+// split shaders due to https://github.com/FarazzShaikh/THREE-CustomShaderMaterial/issues/48
+
+varying vec3 vCSMViewPosition;
+uniform float thickness;
+uniform float penetration;
+uniform float ricochet;
+uniform float caliber;
+uniform float normalization;
+
+void main() {
+  vec3 normalizedNormal = normalize(vNormal);
+  vec3 normalizedViewPosition = normalize(vCSMViewPosition);
+  float cosAngle = dot(normalizedNormal, -normalizedViewPosition);
+  float angle = acos(cosAngle);
+
+  float penetrationChance = 0.0;
+  bool twoCaliberRule = caliber > 2.0 * thickness;
+  bool threeCaliberRule = caliber > 3.0 * thickness;
+  float finalNormalization = twoCaliberRule ? (normalization * 1.4 * caliber) / (2.0 * thickness) : normalization;
+  float finalPenetration = penetration;
+  float effectiveArmor = thickness / cos(angle - finalNormalization);
+
+  if (angle < ricochet) {
+    // no auto-ricochet, resume checks
+    if (threeCaliberRule) {
+      penetrationChance = 1.0;
+    } else {
+      float maxRandomPenetrationBuff = finalPenetration * 0.05;
+      float penetrationDifference = effectiveArmor - finalPenetration;
+
+      if (penetrationDifference > maxRandomPenetrationBuff) {
+        // even with a +5% buff, can't penetrate
+        penetrationChance = 0.0;
+      } else if (penetrationDifference < -maxRandomPenetrationBuff) {
+        // event with a -5% nerf, can penetrate
+        penetrationChance = 1.0;
+      } else {
+        // penetration gradiant
+        penetrationChance = 1.0 - (penetrationDifference + maxRandomPenetrationBuff) / (2.0 * maxRandomPenetrationBuff);
+      }
+    }
+  }
+
+  float h = penetrationChance / PI;
+  float s = 1.0;
+  float v = 1.0;
+  vec4 K = vec4(1.0, 2.0 / 3.0, 1.0 / 3.0, 3.0);
+  vec3 p = abs(fract(h + K.xyz) * 6.0 - K.www);
+  vec3 rgb = v * mix(K.xxx, clamp(p - K.xxx, 0.0, 1.0), s);
+
+  csm_DiffuseColor = vec4(rgb, 1.0);
+}
\ No newline at end of file
diff --git a/src/components/ArmorMesh/shaders/vertex.glsl b/src/components/ArmorMesh/shaders/vertex.glsl
index 829b747fc..afaeda2c0 100644
--- a/src/components/ArmorMesh/shaders/vertex.glsl
+++ b/src/components/ArmorMesh/shaders/vertex.glsl
@@ -1,8 +1,6 @@
-varying vec3 vNormal;
-varying vec3 vViewPosition;
+varying vec3 vCSMViewPosition;
 
 void main() {
   vec4 vViewPosition4 = modelViewMatrix * vec4(position, 1.0);
-  vViewPosition = vViewPosition4.xyz;
-  vNormal = normalMatrix * normal;
+  vCSMViewPosition = vViewPosition4.xyz;
 }
\ No newline at end of file
diff --git a/src/stores/tankopedia.ts b/src/stores/tankopedia.ts
index 20c85898f..fb6201578 100644
--- a/src/stores/tankopedia.ts
+++ b/src/stores/tankopedia.ts
@@ -32,6 +32,7 @@ type Tankopedia = {
     gunPitch: number;
     controlsEnabled: boolean;
     showGrid: boolean;
+    opaqueArmor: boolean;
   };
   mode: TankopediaMode;
 } & (
@@ -70,6 +71,7 @@ export const useTankopedia = create<Tankopedia>()(() => ({
     turretYaw: 0,
     controlsEnabled: true,
     showGrid: true,
+    opaqueArmor: false,
   },
   areTanksAssigned: false,
   mode: 'model',