From f9e0584f00f6aaeab248dd53ff8aedfd447e71aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com> Date: Tue, 17 Oct 2023 20:45:45 -0500 Subject: [PATCH] fix: memory leak in render threads --- src/core/blitzkrieg/svgToPngThreaded.ts | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/core/blitzkrieg/svgToPngThreaded.ts b/src/core/blitzkrieg/svgToPngThreaded.ts index dbba997b4..4fca5ac2f 100644 --- a/src/core/blitzkrieg/svgToPngThreaded.ts +++ b/src/core/blitzkrieg/svgToPngThreaded.ts @@ -19,18 +19,22 @@ function manageQueue() { function cleanup() { workers.push(worker); + worker.off('message', handleMessage); + worker.off('error', handleError); manageQueue(); } + function handleMessage(png: Uint8Array) { + cleanup(); + resolve(Buffer.from(png)); + } + function handleError(error: Error) { + cleanup(); + throw error; + } worker.postMessage(svg); - worker.on('message', (png: Uint8Array) => { - cleanup(); - resolve(Buffer.from(png)); - }); - worker.on('error', (error) => { - cleanup(); - throw error; - }); + worker.on('message', handleMessage); + worker.on('error', handleError); } }