From fd37f72f8cd70251056592d80539af22cbc3016a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tr=C3=A8sAbhi?= <43380238+tresabhi@users.noreply.github.com> Date: Thu, 27 Nov 2025 13:54:36 -0600 Subject: [PATCH] feat: some simplification --- .../TankSandbox/components/Lighting.tsx | 1 + .../components/TankSandbox/index.tsx | 3 +- .../Tankopedia/HeroSection/index.tsx | 43 +++++++------------ 3 files changed, 18 insertions(+), 29 deletions(-) diff --git a/packages/website/src/components/Tankopedia/HeroSection/components/TankSandbox/components/Lighting.tsx b/packages/website/src/components/Tankopedia/HeroSection/components/TankSandbox/components/Lighting.tsx index 70ed33161..7d959c917 100644 --- a/packages/website/src/components/Tankopedia/HeroSection/components/TankSandbox/components/Lighting.tsx +++ b/packages/website/src/components/Tankopedia/HeroSection/components/TankSandbox/components/Lighting.tsx @@ -104,6 +104,7 @@ export function Lighting() { castShadow={highGraphics} decay={1} color="#ffffff" + angle={0} /> ); })} diff --git a/packages/website/src/components/Tankopedia/HeroSection/components/TankSandbox/index.tsx b/packages/website/src/components/Tankopedia/HeroSection/components/TankSandbox/index.tsx index 5c66a69f4..ff5b3e28d 100644 --- a/packages/website/src/components/Tankopedia/HeroSection/components/TankSandbox/index.tsx +++ b/packages/website/src/components/Tankopedia/HeroSection/components/TankSandbox/index.tsx @@ -174,6 +174,8 @@ export const TankSandbox = forwardRef( outline: naked ? "1rem red solid" : undefined, }} > + + {!naked && } {(display === TankopediaDisplay.Model || (display === TankopediaDisplay.DynamicArmor && @@ -190,7 +192,6 @@ export const TankSandbox = forwardRef( {display === TankopediaDisplay.StaticArmor && ( )} - diff --git a/packages/website/src/components/Tankopedia/HeroSection/index.tsx b/packages/website/src/components/Tankopedia/HeroSection/index.tsx index c96a2d9e6..d40a25583 100644 --- a/packages/website/src/components/Tankopedia/HeroSection/index.tsx +++ b/packages/website/src/components/Tankopedia/HeroSection/index.tsx @@ -1,6 +1,6 @@ import { Box, Flex } from "@radix-ui/themes"; import { times } from "lodash-es"; -import { Suspense, useEffect, useMemo, useRef } from "react"; +import { useEffect, useMemo, useRef } from "react"; import { awaitableTankDefinitions } from "../../../core/awaitables/tankDefinitions"; import { useFullScreen } from "../../../hooks/useFullScreen"; import { Duel } from "../../../stores/duel"; @@ -99,11 +99,11 @@ export function HeroSection({ skeleton }: MaybeSkeletonComponentProps) { isFullScreen ? "100vh" : disturbed - ? "calc(100svh - 8rem)" - : { - initial: "28rem", - md: "calc(100svh - 14rem)", - } + ? "calc(100svh - 8rem)" + : { + initial: "28rem", + md: "calc(100svh - 14rem)", + } } maxWidth={isFullScreen ? undefined : "120rem"} flexGrow="1" @@ -120,30 +120,17 @@ export function HeroSection({ skeleton }: MaybeSkeletonComponentProps) { position="relative" > - + - - {!skeleton && ( - - )} - + {!skeleton && ( + + )}